From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dirk-Jan C. Binnema Newsgroups: gmane.emacs.bugs Subject: bug#8454: deftheme, :inherit & overriding existing values Date: Mon, 09 May 2011 23:41:34 +0300 Organization: DJCBSoftware Message-ID: <20110509204134.4AFEE39C5D4@djcbsoftware.nl> References: <20110507091706.DC97939C792@djcbsoftware.nl> <4DC54D3D.7090409@gmail.com> <87r58980f7.fsf@stupidchicken.com> <87mxix7xvm.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: dough.gmane.org 1304973734 21876 80.91.229.12 (9 May 2011 20:42:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 9 May 2011 20:42:14 +0000 (UTC) Cc: Christoph Scholtes , 8454@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 09 22:42:08 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QJXHL-0000NO-OT for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 May 2011 22:42:08 +0200 Original-Received: from localhost ([::1]:50743 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJXHL-0002tR-BS for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 May 2011 16:42:07 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:43616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJXHI-0002t8-4S for bug-gnu-emacs@gnu.org; Mon, 09 May 2011 16:42:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QJXHG-0006Vz-SZ for bug-gnu-emacs@gnu.org; Mon, 09 May 2011 16:42:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJXHG-0006Vt-MS for bug-gnu-emacs@gnu.org; Mon, 09 May 2011 16:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QJXHG-00015c-8G; Mon, 09 May 2011 16:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dirk-Jan C. Binnema Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2011 20:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8454 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8454-submit@debbugs.gnu.org id=B8454.13049737094165 (code B ref 8454); Mon, 09 May 2011 20:42:02 +0000 Original-Received: (at 8454) by debbugs.gnu.org; 9 May 2011 20:41:49 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJXH2-000158-CS for submit@debbugs.gnu.org; Mon, 09 May 2011 16:41:48 -0400 Original-Received: from vs12.mail.saunalahti.fi ([195.197.172.107]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJXGz-00014t-PZ for 8454@debbugs.gnu.org; Mon, 09 May 2011 16:41:46 -0400 Original-Received: from saunalahti-vams (localhost [127.0.0.1]) by vs12.mail.saunalahti.fi (Postfix) with SMTP id 8E53524003F; Mon, 9 May 2011 23:41:38 +0300 (EEST) Original-Received: from vs12.mail.saunalahti.fi ([127.0.0.1]) by vs12.mail.saunalahti.fi ([195.197.172.107]) with SMTP (gateway) id A0501C8C574; Mon, 09 May 2011 23:41:38 +0300 Original-Received: from gw01.mail.saunalahti.fi (gw01.mail.saunalahti.fi [195.197.172.115]) by vs12.mail.saunalahti.fi (Postfix) with ESMTP id 84FDD24003F; Mon, 9 May 2011 23:41:38 +0300 (EEST) Original-Received: from djcbsoftware.nl (a88-112-253-18.elisa-laajakaista.fi [88.112.253.18]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by gw01.mail.saunalahti.fi (Postfix) with ESMTP id 2CD9715152E; Mon, 9 May 2011 23:41:34 +0300 (EEST) Original-Received: from cthulhu.mindcrime.djcbsoftware.nl (cthulhu [127.0.0.1]) by djcbsoftware.nl (Postfix) with ESMTP id 4AFEE39C5D4; Mon, 9 May 2011 23:41:34 +0300 (EEST) In-Reply-To: <87mxix7xvm.fsf@stupidchicken.com> Mail-Reply-To: djcb@djcbsoftware.nl User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/24.0 Mule/6.0 (HANACHIRUSATO) X-Antivirus: VAMS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 09 May 2011 16:42:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46361 Archived-At: Hi, >>>>> On Sun, 08 May 2011 16:14:53 -0400, Chong Yidong ("CYD") wrote: CYD> Chong Yidong writes: >> I'm afraid both bug reports are too vague for me to figure out exactly >> what is supposed to be going wrong. Could someone provide a precise, >> step-by-step recipe for reproducing the problem? Sorry about the 'vagueness' - but glad you found it out anyhow. CYD> OK, I found a bug in the case where defface is called after loading a CYD> theme with settings for that face. The defface settings were not being CYD> applied; I've checked a fix into the trunk. However, I'm not sure this CYD> is the issue you are talking about, since this bug was not specific to CYD> the :inherit property. Could you check if your problem is fixed? No, it does solve the problem, but I guess below confirms my suspicion.. CYD> One possible source of confusion, which may apply to Dirk-Jan's report, CYD> is that :inherit only tells Emacs to consult the parent face if a face CYD> attribute is unspecified. If the attribute is specified, it overrides CYD> the inheritance. So if your Custom theme want to "cancel out", say, any CYD> existing foreground attribute setting, you need something like CYD> '(froob ((t (:foreground unspecified :inherit parent-face)))) Ok, yes that is what happens. I guess this could work, but in practice it makes :inherit rather suboptimal -- imagine switching from one theme to another, you'd have to explicitly cancel out every attribute the other theme may have set. Best wishes, Dirk. -- Dirk-Jan C. Binnema Helsinki, Finland e:djcb@djcbsoftware.nl w:www.djcbsoftware.nl pgp: D09C E664 897D 7D39 5047 A178 E96A C7A1 017D DA3C