From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joost Helberg Subject: Re: error in calculating percentages in clocktables Date: Fri, 03 Dec 2010 11:13:28 +0100 (CET) Message-ID: <20101203.111328.221844449.joost@snow.nl> References: <20101129.115616.179398633.joost@snow.nl> <3F1F7C35-B348-4A8A-9F1E-91E7D78B5092@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=48153 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POSdy-0001Kx-6H for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 05:13:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POSdw-0002TD-Sn for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 05:13:34 -0500 Received: from mx.snow.nl ([213.154.248.146]:32914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POSdw-0002SM-Kp for emacs-orgmode@gnu.org; Fri, 03 Dec 2010 05:13:32 -0500 In-Reply-To: <3F1F7C35-B348-4A8A-9F1E-91E7D78B5092@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: carsten.dominik@gmail.com Cc: emacs-orgmode@gnu.org Carsten, your more general approach works fine for me. The pushed fix seems allright. many regards, Joost >>>>> "Carsten" == Carsten Dominik writes: > Subject: Re: [Orgmode] error in calculating percentages in clocktables > From: Carsten Dominik > To: Joost Helberg > Cc: emacs-orgmode@gnu.org > Date: Fri, 3 Dec 2010 09:52:57 +0100 > Hi Joost, > thanks for this, but the new tables are complex and the patch was not > general enough. I have just pushed a fix which I think is correct. > Please verify. > - Carsten > On Nov 29, 2010, at 11:56 AM, Joost Helberg wrote: >> ls, >> >> I'm using clocktables and encountered an issue in calculating the >> percentage in the last column. Some columns have moved 1 left in the >> head-revision, but the generated formula was not changed. >> Hence the following patch. The percentages come out OK with this >> patch. >> >> Can someone using clocktables verify that this patch is correct and >> doesn't break other stuff? >> >> diff --git a/lisp/org-clock.el b/lisp/org-clock.el >> index eb859df..0c7c73b 100644 >> --- a/lisp/org-clock.el >> +++ b/lisp/org-clock.el >> @@ -2173,9 +2173,9 @@ from the dynamic block defintion." >> (format >> "\n#+TBLFM: $%d='(org-clock-time%% @%d$%d $%d..$%d);%%.1f" >> pcol >> - (+ 2 (if narrow 1 0)) >> - (+ 3 (if multifile 1 0)) >> - (+ (if multifile 1 0) 3) >> + (+ 1 (if narrow 1 0)) >> + (+ 2 (if multifile 1 0)) >> + (+ (if multifile 1 0) 2) >> (1- pcol))) >> (setq recalc t)) >> ((stringp formula) >> >> regards, >> >> Joost Helberg >> >> -- >> Snow B.V. http://snow.nl >> >> _______________________________________________ >> Emacs-orgmode mailing list >> Please use `Reply All' to send replies to the list. >> Emacs-orgmode@gnu.org >> http://lists.gnu.org/mailman/listinfo/emacs-orgmode > - Carsten -- Snow B.V. http://snow.nl