From: Agustin Martin <agustin.martin@hispalinux.es>
To: 7343@debbugs.gnu.org, Brandon Craig Rhodes <brandon@rhodesmill.org>
Subject: bug#7343: Making flyspell incredibly fast when checking whole files
Date: Mon, 8 Nov 2010 19:46:37 +0100 [thread overview]
Message-ID: <20101108184636.GA9940@agmartin.aq.upm.es> (raw)
In-Reply-To: <jwvtyjrsnck.fsf-monnier+emacs@gnu.org>
On Mon, Nov 08, 2010 at 01:10:42PM -0500, Stefan Monnier wrote:
> > Anyway, flyspell does try to take advantage of the above behavior by
> > checking whether a region is larger than flyspell-large-region
> > characters, and if so then it runs the spell checker as a separate
> > process with "-l". But then it does something that, in many cases, is
> > rather ruinous: it takes every misspelling so identified, and passes it
> > *back* through the normal interactive spell-checking logic! This is
> > because all of the real logic of what to do with a misspelling - how to
> > highlight it, how to search for nearby instances of the same word, how
> > to cache spellings, and so forth - is bound up in flyspell-word, so the
> > flyspell-external-point-words function, which processes the actual
> > misspellings discovered by flyspell-large-region, really has no other
> > choice but to call flyspell-word for each misspelling.
>
> IIUC this sounds very good (tho it only speeds up flyspell-region and
> not flyspell-post-command-hook) and the patch looks good and small
> enough for inclusion as a "tiny patch". Agustin, could you double check
> that it's OK and install it in the trunk if so?
Hi,
I also agree that Brandon's patch sounds very good, although I could not yet
really test it. I hope to have time for this in no more than two or three
days.
I will also add something in the docstring about the new option.
--
Agustin
next prev parent reply other threads:[~2010-11-08 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 14:03 bug#7343: Making flyspell incredibly fast when checking whole files Brandon Craig Rhodes
2010-11-08 18:10 ` Stefan Monnier
2010-11-08 18:46 ` Agustin Martin [this message]
2010-11-10 14:44 ` Agustin Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108184636.GA9940@agmartin.aq.upm.es \
--to=agustin.martin@hispalinux.es \
--cc=7343@debbugs.gnu.org \
--cc=brandon@rhodesmill.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.