From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#7185: 24.0.50; c-fill-paragraph regression Date: Sun, 31 Oct 2010 12:04:43 +0000 Message-ID: <20101031120443.GA2481@muc.de> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1288527212 6604 80.91.229.12 (31 Oct 2010 12:13:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 31 Oct 2010 12:13:32 +0000 (UTC) To: John Yates , 7185-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 31 13:13:27 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PCWmt-00026E-9h for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Oct 2010 13:13:27 +0100 Original-Received: from localhost ([127.0.0.1]:59604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PCWms-0001uV-Jp for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Oct 2010 08:13:26 -0400 Original-Received: from [140.186.70.92] (port=50108 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PCWml-0001uF-TX for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2010 08:13:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PCWmk-0003qe-Pt for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2010 08:13:19 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PCWmj-0003q3-Gh; Sun, 31 Oct 2010 08:13:17 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PCWOI-0000JJ-MQ; Sun, 31 Oct 2010 07:48:02 -0400 Resent-From: Alan Mackenzie Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sun, 31 Oct 2010 11:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 7185 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: Mail-Followup-To: 7185@debbugs.gnu.org, acm@muc.de Original-Received: via spool by 7185-done@debbugs.gnu.org id=D7185.12885256291179 (code D ref 7185); Sun, 31 Oct 2010 11:48:02 +0000 Original-Received: (at 7185-done) by debbugs.gnu.org; 31 Oct 2010 11:47:09 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PCWNQ-0000Iy-6S for submit@debbugs.gnu.org; Sun, 31 Oct 2010 07:47:08 -0400 Original-Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PCWNN-0000Ic-KK for 7185-done@debbugs.gnu.org; Sun, 31 Oct 2010 07:47:06 -0400 Original-Received: (qmail 86122 invoked by uid 3782); 31 Oct 2010 11:51:21 -0000 Original-Received: from acm.muc.de (pD9E23EE4.dip.t-dialin.net [217.226.62.228]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Sun, 31 Oct 2010 12:51:19 +0100 Original-Received: (qmail 2690 invoked by uid 1000); 31 Oct 2010 12:04:43 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 31 Oct 2010 07:48:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41306 Archived-At: Hi, John, On Sun, Oct 10, 2010 at 11:53:15AM -0400, John Yates wrote: > ==[ Before filling comment ]== > > /* > >> abc > >> def > */ > { > return 0; > } > ==[ Emacs 23.1.1, after filling (sub-optimal) ]== > > /* > >> abc def */ > { > return 0; > } > ==[ Emacs 24.0.50.1, after filling (much worse) ]== > > /* > >> abc def */ { return 0; } > > The problem seems to associated with the fact the the comment close > token (*/) is not preceded by an initial space (which, had it been > present, would have cause the opening and closing asterisks to be > aligned. It was actually an off-by-1 error in `c-mask-paragraph'. It's now fixed (I hope :-). I'd by grateful if you could try out the fix (now in the bzr repository), just to make sure I haven't introduced a new bug. Thanks for such a high quality bug report! -- Alan Mackenzie (Nuremberg, Germany).