From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Agustin Martin Newsgroups: gmane.emacs.bugs Subject: bug#7230: 24.0.50; Regression: Many dictionaries not found by ispell.el Date: Mon, 18 Oct 2010 18:16:47 +0200 Message-ID: <20101018161647.GA4936@agmartin.aq.upm.es> References: <20101018112247.GA14951@agmartin.aq.upm.es> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1287420170 5800 80.91.229.12 (18 Oct 2010 16:42:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 18 Oct 2010 16:42:50 +0000 (UTC) To: Knut Anders Hatlen , 7230-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 18 18:42:49 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P7snN-0004T2-T9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Oct 2010 18:42:46 +0200 Original-Received: from localhost ([127.0.0.1]:50090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P7snM-0004AL-1x for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Oct 2010 12:42:44 -0400 Original-Received: from [140.186.70.92] (port=38013 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P7snG-00047k-46 for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2010 12:42:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P7snE-0002r8-CQ for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2010 12:42:37 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P7snE-0002r4-Aw for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2010 12:42:36 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P7sLa-0007ep-2d for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2010 12:14:02 -0400 Resent-From: Agustin Martin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Oct 2010 16:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 7230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 7230@debbugs.gnu.org, agustin.martin@hispalinux.es Original-Received: via spool by 7230-done@debbugs.gnu.org id=D7230.128741838729423 (code D ref 7230); Mon, 18 Oct 2010 16:14:01 +0000 Original-Received: (at 7230-done) by debbugs.gnu.org; 18 Oct 2010 16:13:07 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P7sKh-0007eW-6S for submit@debbugs.gnu.org; Mon, 18 Oct 2010 12:13:07 -0400 Original-Received: from edison.ccupm.upm.es ([138.100.198.71] helo=smtp.upm.es) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P7sKf-0007eA-4t for 7230-done@debbugs.gnu.org; Mon, 18 Oct 2010 12:13:06 -0400 Original-Received: from agmartin.aq.upm.es (Agmartin.aq.upm.es [138.100.41.131]) by smtp.upm.es (8.14.3/8.14.3/edison-001) with ESMTP id o9IGGl7b016425; Mon, 18 Oct 2010 18:16:47 +0200 Original-Received: by agmartin.aq.upm.es (Postfix, from userid 1000) id 868314645D; Mon, 18 Oct 2010 18:16:47 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20101018112247.GA14951@agmartin.aq.upm.es> User-Agent: Mutt/1.5.20 (2009-06-14) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 18 Oct 2010 12:14:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40956 Archived-At: On Mon, Oct 18, 2010 at 01:22:47PM +0200, Agustin Martin wrote: > On Sun, Oct 17, 2010 at 07:41:16PM +0200, Knut Anders Hatlen wrote: > > > > On a system with Aspell 0.60.6 with English dictionaries installed, > > evaluating the following expression successfully changes the dictionary > > on Emacs 23.2: > > > > (progn > > (require 'ispell) > > (ispell-change-dictionary "british-ize")) > > > > On Emacs 24 it fails: > > Thanks for noticing and sorry for the bug. I thought it was behaving > correctly since a lot of English variants were listed and unfortunately > did not notice that some of them were missing, my fault. I really wonder > how no one found this before. > > This change was introduced to deal with portuguese, that has no pt.dat, but > pt_BR or pt_PT. > > I am currently playing with attached patch, that tries different .dat > matches. This should be better than before, and deal with former case plus > portuguese. Will test a bit more and commit if no problems appear. Just committed a change that should look for both xx.dat and xx_YY.dat files for xx_YY.. aspell dicts. Includes also some function reorganization and a proper docstring. This should fix this problem, so I am closing the bug report. Please reopen if needed. > (defun ispell-aspell-find-dictionary (dict-name) Function name is a bit misleading. Fortunately, seems it is only used internally by ispell.el and is not intended for external use. I left it with its current name, but something like `ispell-aspell-find-dict-params' looks more appropriate. Will think if worths renaming and declaring old name obsolete. Thanks for your feedback, -- Agustin