From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: richard_sharman@mitel.com Newsgroups: gmane.emacs.bugs Subject: bug#7132: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9 Date: Wed, 29 Sep 2010 10:02:09 -0400 Message-ID: <201009291402.o8TE2965002287@sharmanpc.mitel.com> NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1285776927 22331 80.91.229.12 (29 Sep 2010 16:15:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 29 Sep 2010 16:15:27 +0000 (UTC) To: 7132@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 29 18:15:25 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P0zJU-0005YO-ON for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Sep 2010 18:15:25 +0200 Original-Received: from localhost ([127.0.0.1]:38301 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0zJT-00016V-Ul for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Sep 2010 12:15:23 -0400 Original-Received: from [140.186.70.92] (port=48665 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0zFz-0006ll-8N for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 12:11:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0zFx-0004M3-TP for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 12:11:47 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45413) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0zFx-0004Lx-Pq for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 12:11:45 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P0ykH-0005hO-VY; Wed, 29 Sep 2010 11:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: richard_sharman@mitel.com Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Sep 2010 15:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7132 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.128577468121869 (code B ref -1); Wed, 29 Sep 2010 15:39:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Sep 2010 15:38:01 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0yjI-0005ga-3F for submit@debbugs.gnu.org; Wed, 29 Sep 2010 11:38:01 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0xCA-0004xd-8j for submit@debbugs.gnu.org; Wed, 29 Sep 2010 09:59:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0xEp-0006XD-EW for submit@debbugs.gnu.org; Wed, 29 Sep 2010 10:02:35 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:38386) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0xEp-0006X9-9T for submit@debbugs.gnu.org; Wed, 29 Sep 2010 10:02:27 -0400 Original-Received: from [140.186.70.92] (port=60802 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0xEh-0004kS-9f for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 10:02:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0xEb-0006Uj-IE for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 10:02:19 -0400 Original-Received: from smtp.mitel.com ([216.191.234.102]:50517) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0xEb-0006UL-Ax for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 10:02:13 -0400 Original-Received: from localhost (smtp.mitel.com [127.0.0.1]) by smtp.mitel.com (Postfix) with ESMTP id 1FC9F2C04A for ; Wed, 29 Sep 2010 10:02:10 -0400 (EDT) X-Virus-Scanned: by amavisd-new (virusonly) at mitel.com Original-Received: from smtp.mitel.com ([127.0.0.1]) by localhost (smtp.mitel.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T3iUrYH06V6Y for ; Wed, 29 Sep 2010 10:02:09 -0400 (EDT) Original-Received: from sharmanpc.mitel.com (unknown [10.35.21.61]) by smtp.mitel.com (Postfix) with ESMTP id E2FA42C041 for ; Wed, 29 Sep 2010 10:02:09 -0400 (EDT) Original-Received: from sharmanpc.mitel.com (localhost.localdomain [127.0.0.1]) by sharmanpc.mitel.com (8.13.1/8.13.1) with ESMTP id o8TE29hw002288 for ; Wed, 29 Sep 2010 10:02:09 -0400 Original-Received: (from sharman@localhost) by sharmanpc.mitel.com (8.13.1/8.13.1/Submit) id o8TE2965002287; Wed, 29 Sep 2010 10:02:09 -0400 X-Authentication-Warning: sharmanpc.mitel.com: sharman set sender to richard_sharman@mitel.com using -f X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Mailman-Approved-At: Wed, 29 Sep 2010 11:37:58 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 29 Sep 2010 11:39:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40547 Archived-At: The control mouse 1 in the fringe area is supposed to toggle whether breakpoints are enabled or not. It fails to do this when the breakpoint number exceeds 9. This is because it only picks up the a single digit of a breakpoint number due to a bug in the string-match regexp argument. Here is a fix: sharmanpc 7% diff -c gdb-ui.el.orig gdb-ui.el *** gdb-ui.el.orig Wed Sep 29 09:41:10 2010 --- gdb-ui.el Wed Sep 29 09:42:05 2010 *************** *** 2098,2104 **** (setq obj (overlay-get overlay 'before-string)))) (when (stringp obj) (let* ((bptno (get-text-property 0 'gdb-bptno obj))) ! (string-match "\\([0-9+]\\)*" bptno) (gdb-enqueue-input (list (concat gdb-server-prefix --- 2098,2104 ---- (setq obj (overlay-get overlay 'before-string)))) (when (stringp obj) (let* ((bptno (get-text-property 0 'gdb-bptno obj))) ! (string-match "\\([0-9]+\\)*" bptno) (gdb-enqueue-input (list (concat gdb-server-prefix sharmanpc 8% diff -c gdb-ui.el.orig gdb-ui.el > gdb-ui.el.cdif sharmanpc 9% In GNU Emacs 23.1.1 (i686-pc-linux-gnu, X toolkit) of 2009-11-20 on sharmanpc.mitel.com Windowing system distributor `The X.Org Foundation', version 11.0.60802000 configured using `configure '--with-x-toolkit=athena' '--without-toolkit-scroll-bars' '--without-sound'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: C value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Shell Minor modes in effect: shell-dirtrack-mode: t global-highlight-changes-mode: t highlight-changes-visible-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Recent input: C-f C-a C-k ~ / t m p / g d b - u i . e l C-g C-x C-b C-x o C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-x o M-x s h e p u s n d SPC ~ / h d SPC ~ / t m p C-x o C-x M-f C-x o c p SPC C-y SPC . g u n z i p SPC f g g d b u - u I I M-p C-a C-k C-p C-f C-f C-f C-f C-f C-f C-f C-2 C-M-f M-w C-n C-x 4 C-f C-y . e l C-x o l m v SPC C-p C-f C-f C-f C-f C-2 C-M-f C-M-f M-w C-n C-y SPC C-y . o r i g C-x o C-x C-b C-x o C-n C-n C-s c h g e C-a C-n C-n C-n C-n C-M-b C-s C-w C-w C-w C-w C-w C-x o C-s C-s C-a C-x o C-a C-a C-s C-w C-w C-w C-w C-w C-w C-w C-s C-s C-a C-a C-x o C-f C-t C-a C-x C-s M-x e v a l - c u C-x o M-x s h e d i f f SPC c - c SPC C-p C-f C-f C-f C-f C-f C-f C-b C-2 C-e M-w C-n C-y C-x u C-e C-y SPC C-y M-p SPC > S-SPC M-b M-b M-b C-2 C-M-f C-M-f M-w C-e C-y . c d i f M-x r e p o r t - e m a Recent messages: Mark saved where search started [2 times] Mark set [2 times] Saving file /home/gx5000/sharman/tmp/gdb-ui.el... Wrote /home/gx5000/sharman/tmp/gdb-ui.el ad-handle-definition: `gdb-invalidate-frames' got redefined Mark set [2 times] Undo! Mark set [2 times] History item: 1 Mark set [2 times]