From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Agustin Martin Newsgroups: gmane.emacs.bugs Subject: bug#6143: 6143 ispell not fixed Date: Fri, 3 Sep 2010 12:19:22 +0200 Message-ID: <20100903101921.GA3217@agmartin.aq.upm.es> References: <87y6ftvphy.fsf@jidanni.org> <871vavtjqg.fsf@jidanni.org> <20100726093848.GA3291@agmartin.aq.upm.es> <20100902124747.GA10288@agmartin.aq.upm.es> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1283510403 3207 80.91.229.12 (3 Sep 2010 10:40:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 3 Sep 2010 10:40:03 +0000 (UTC) To: 6143@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 03 12:40:01 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OrTgd-0006ei-43 for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Sep 2010 12:39:59 +0200 Original-Received: from localhost ([127.0.0.1]:42796 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OrTgc-0004S8-Hd for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Sep 2010 06:39:58 -0400 Original-Received: from [140.186.70.92] (port=51787 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OrTgX-0004S3-4l for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2010 06:39:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OrTgV-0000sg-T8 for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2010 06:39:52 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55586) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OrTgV-0000sb-Ov for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2010 06:39:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OrTLO-0004TW-3h; Fri, 03 Sep 2010 06:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Agustin Martin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Sep 2010 10:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6143 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6143-submit@debbugs.gnu.org id=B6143.128350906017191 (code B ref 6143); Fri, 03 Sep 2010 10:18:02 +0000 Original-Received: (at 6143) by debbugs.gnu.org; 3 Sep 2010 10:17:40 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OrTL2-0004TD-Fn for submit@debbugs.gnu.org; Fri, 03 Sep 2010 06:17:40 -0400 Original-Received: from fibonacci.ccupm.upm.es ([138.100.198.70] helo=smtp.upm.es) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OrTKz-0004T7-VP for 6143@debbugs.gnu.org; Fri, 03 Sep 2010 06:17:38 -0400 Original-Received: from agmartin.aq.upm.es (Agmartin.aq.upm.es [138.100.41.131]) by smtp.upm.es (8.14.3/8.14.3/fibonacci-001) with ESMTP id o83AJMIX003023; Fri, 3 Sep 2010 12:19:22 +0200 Original-Received: by agmartin.aq.upm.es (Postfix, from userid 1000) id 22009461CA; Fri, 3 Sep 2010 12:19:22 +0200 (CEST) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 03 Sep 2010 06:18:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:39922 Archived-At: On Thu, Sep 02, 2010 at 06:01:10PM +0200, Stefan Monnier wrote: > > I have just commited a change that should use "~/" as default-directory > > unless Ispell per-directory personal dicts are used and not in a minibuffer > > under XEmacs. > > Could you explain (ideally in a comment in the code) why the minibuffer > case is important, Minibuffer case is now a very marginal case which will currently appear only when directory-specific dictionaries are used under Ispell, and someone tries to spell-check stuff in the minibuffer (like jidanni did for FSF Emacs). Without the change, in that very marginal case, everytime the minibuffer is closed ispell process will be killed. > why we distinguish the Emacs-vs-XEmacs cases, I try to introduce as few XEmacs incompatibilities as possible, even if current ispell.el and flyspell.el do not work under XEmacs. I still use FSF Emacs ispell.el and flyspell.el as base for Debian, patched so they work even with XEmacs. I'd ideally like to decrease the number of Debian changes added just for XEmacs compatibility by committing some of them to bzr repo. Also, since most of the Debian changes are already committed to FSF Emacs bzr repo, I'd like to sit down and see what else is needed for FSF Emacs ispell.el and flyspell.el to be integrated with our Debian dictionary registration mechanism. If that seems of enough wide use, I'd like to push changes to bzr. I have some other changes pushed to Debian that should go into FSF Emacs repo (I sometimes try things first in Debian). > and why > we use (fboundp 'minibuffer-selected-window) rather than (featurep > 'xemacs) to check whether we're in XEmacs (I see this use comes > from the earlier code, but maybe it's an opportunity to change it, > since (featurep 'xemacs) is treated specially by the byte-compiler to > generate more efficient code and to avoid spurious warnings). Someone asked Stephen Turnbull if it was posible to implement `minibuffer-selected-window' in XEmacs and he asked for code. So, I left that possibility open. Unless is a known design choice, I usually prefer to check for variable/function availability, in case that is later implemented. -- Agustin