From: Agustin Martin <agustin.martin@hispalinux.es>
To: 6143@debbugs.gnu.org
Subject: bug#6143: 6143 ispell not fixed
Date: Fri, 3 Sep 2010 12:19:22 +0200 [thread overview]
Message-ID: <20100903101921.GA3217@agmartin.aq.upm.es> (raw)
In-Reply-To: <jwvfwxs6swk.fsf-monnier+emacs@gnu.org>
On Thu, Sep 02, 2010 at 06:01:10PM +0200, Stefan Monnier wrote:
> > I have just commited a change that should use "~/" as default-directory
> > unless Ispell per-directory personal dicts are used and not in a minibuffer
> > under XEmacs.
>
> Could you explain (ideally in a comment in the code) why the minibuffer
> case is important,
Minibuffer case is now a very marginal case which will currently appear only
when directory-specific dictionaries are used under Ispell, and someone tries
to spell-check stuff in the minibuffer (like jidanni did for FSF Emacs).
Without the change, in that very marginal case, everytime the minibuffer is
closed ispell process will be killed.
> why we distinguish the Emacs-vs-XEmacs cases,
I try to introduce as few XEmacs incompatibilities as possible, even if
current ispell.el and flyspell.el do not work under XEmacs. I still use FSF
Emacs ispell.el and flyspell.el as base for Debian, patched so they work even
with XEmacs.
I'd ideally like to decrease the number of Debian changes added just for
XEmacs compatibility by committing some of them to bzr repo.
Also, since most of the Debian changes are already committed to FSF Emacs
bzr repo, I'd like to sit down and see what else is needed for FSF Emacs
ispell.el and flyspell.el to be integrated with our Debian dictionary
registration mechanism. If that seems of enough wide use, I'd like to push
changes to bzr.
I have some other changes pushed to Debian that should go into FSF Emacs
repo (I sometimes try things first in Debian).
> and why
> we use (fboundp 'minibuffer-selected-window) rather than (featurep
> 'xemacs) to check whether we're in XEmacs (I see this use comes
> from the earlier code, but maybe it's an opportunity to change it,
> since (featurep 'xemacs) is treated specially by the byte-compiler to
> generate more efficient code and to avoid spurious warnings).
Someone asked Stephen Turnbull if it was posible to implement
`minibuffer-selected-window' in XEmacs and he asked for code. So, I left
that possibility open.
Unless is a known design choice, I usually prefer to check for
variable/function availability, in case that is later implemented.
--
Agustin
next prev parent reply other threads:[~2010-09-03 10:19 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <handler.6143.D6143.127374871827801.notifdone@debbugs.gnu.org>
2010-05-09 1:21 ` [emacs-w3m:11218] 24.0.50; don't ispell-kill-ispell over and over jidanni
2010-05-11 13:20 ` bug#6143: " Agustin Martin
2010-05-11 14:40 ` Stefan Monnier
2010-05-11 15:18 ` Agustin Martin
2010-05-12 10:26 ` Agustin Martin
2010-05-12 13:30 ` Lennart Borgman
2010-05-12 14:35 ` Agustin Martin
2010-05-12 14:28 ` Stefan Monnier
2010-05-13 11:05 ` Agustin Martin
2010-05-28 13:45 ` bug#6143: closed (Re: bug#6143: 24.0.50; don't ispell-kill-ispell over and over) jidanni
2010-06-20 4:47 ` bug#6143: ispell killing still not fixed jidanni
2010-06-21 12:10 ` Agustin Martin
2010-06-23 2:19 ` jidanni
2010-06-24 11:35 ` Agustin Martin
2010-06-24 14:43 ` jidanni
2010-06-24 15:23 ` Agustin Martin
2010-06-24 15:51 ` Agustin Martin
2010-06-24 16:16 ` Agustin Martin
2010-06-24 23:52 ` jidanni
2010-06-25 8:30 ` Agustin Martin
2010-07-10 2:30 ` bug#6143: totally " agustin.martin
2010-07-22 19:11 ` bug#6143: 6143 ispell " jidanni
2010-07-23 11:18 ` Agustin Martin
2010-07-24 5:35 ` Dan Nicolaescu
2010-07-26 9:38 ` Agustin Martin
2010-07-26 9:59 ` Agustin Martin
2010-07-26 10:25 ` Agustin Martin
2010-07-27 12:03 ` Agustin Martin
2010-07-27 18:16 ` Dan Nicolaescu
2010-07-27 19:04 ` Dan Nicolaescu
2010-07-29 11:41 ` Agustin Martin
2010-07-29 13:07 ` Stefan Monnier
2010-09-02 12:47 ` Agustin Martin
2010-09-02 13:03 ` jidanni
2010-10-26 10:20 ` bug#6143: ispell killing still " Agustin Martin
2010-09-02 16:01 ` bug#6143: 6143 ispell " Stefan Monnier
2010-09-03 10:19 ` Agustin Martin [this message]
2010-07-23 19:30 ` jidanni
2010-07-26 3:54 ` jidanni
2010-07-26 14:21 ` jidanni
2010-07-27 17:35 ` jidanni
2010-07-29 20:42 ` jidanni
2010-08-13 14:20 ` jidanni
2010-10-26 12:07 ` bug#6143: ispell killing still " jidanni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100903101921.GA3217@agmartin.aq.upm.es \
--to=agustin.martin@hispalinux.es \
--cc=6143@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.