Bug: org-timer-start with offset [6.36trans]

Bug: org-timer-start with offset [6.36trans]

[Christian Moe]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See

http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

Hi,

I get errors when calling org-timer-start with an offset (e.g. 30 
seconds) in all cases except picking the offset up from a timestamp at 
point.


The following fails:

- Doing `C-u 30 C-c C-x C-0' or `C-u 30 M-x org-start-timer'

- Evaluating the expressions

(org-timer-start 30)

(org-timer-start "0:00:30")

Here's a backtrace of the latter case:

--------------------

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
string-match("\\([-+]?[0-9]+\\):\\([0-9]\\{2\\}\\):\\([0-9]\\{2\\}\\)" nil)
org-timer-hms-to-secs(nil)
org-timer-start("0:00:30")
eval((org-timer-start "0:00:30"))
eval-last-sexp-1(nil)
eval-last-sexp(nil)
call-interactively(eval-last-sexp nil nil)

---------------------

This works:

- Starting the timer without an offset

- Starting the timer with `C-u C-x C-x C-0' with point on the timestamp 
`0:00:30' -- I'm correctly prompted and the timer starts.


Yours,
Christian


My setup:


Emacs : GNU Emacs 23.1.1 (powerpc-apple-darwin9.8.0, NS 
apple-appkit-949.54)
of 2010-01-18 on Celebrian.local
Package: Org-mode version 6.36trans

current state:
==============
(setq
org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
org-agenda-files '("~/org/holysites.org" "~/org/agw.org" "~/org/gloss.org"
"~/org/cm.org" "~/org/yme.org")
org-export-latex-default-packages-alist '(("AUTO" "inputenc" t)
("T1" "fontenc" t) ("" "fixltx2e" nil)
("" "graphicx" t) ("" "longtable" nil)
("" "float" nil) ("" "wrapfig" nil)
("" "soul" t) ("" "t1enc" t)
("" "textcomp" t) ("" "marvosym" nil)
("" "wasysym" nil) ("" "latexsym" t)
("" "amssymb" t) ("" "hyperref" nil)
"\\tolerance=1000")
org-metaup-hook '(org-babel-load-in-session-maybe)
org-export-preprocess-after-blockquote-hook 
'(org-special-blocks-make-special-cookies)
org-after-todo-state-change-hook '(org-clock-out-if-current)
org-export-html-after-blockquotes-hook 
'(org-special-blocks-convert-html-special-cookies)
org-export-blocks-postblock-hook '(org-exp-res/src-name-cleanup)
org-export-latex-format-toc-function 'org-export-latex-format-toc-default
org-export-latex-after-blockquotes-hook 
'(org-special-blocks-convert-latex-special-cookies)
org-export-preprocess-hook '(org-export-blocks-preprocess)
org-tab-first-hook '(org-hide-block-toggle-maybe
org-babel-hide-result-toggle-maybe)
outline-regexp "\\*+ "
org-src-mode-hook '(org-src-mode-configure-edit-buffer)
org-confirm-shell-link-function 'yes-or-no-p
org-export-first-hook '(org-beamer-initialize-open-trackers)
org-todo-keywords '((sequence "TODO" "|" "DONE")
(sequence "GET" "SOLICITED" "|" "AGREED" "DRAFT1" "DRAFT2"
"EDITED" "FINAL")
(sequence "|" "CANCELED"))
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-default-notes-file "~/org/notes.org"
org-directory "~/org/"
org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
org-export-preprocess-before-normalizing-links-hook 
'(org-remove-file-link-modifiers)
org-mode-hook '(org-mode-reftex-setup
#[nil "\300\301\302\303\304$\207"
[org-add-hook change-major-mode-hook org-show-block-all append
local]
5]
#[nil "\300\301\302\303\304$\207"
[org-add-hook change-major-mode-hook org-babel-show-result-all
append local]
5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
org-ctrl-c-ctrl-c-hook '(org-babel-lob-execute-maybe 
org-babel-hash-at-point
org-babel-execute-src-block-maybe)
org-confirm-elisp-link-function 'yes-or-no-p
org-export-interblocks '((lob org-babel-exp-lob-one-liners)
(src org-babel-exp-inline-src-blocks))
org-occur-hook '(org-first-headline-recenter)
org-from-is-user-regexp "\\ "
org-export-preprocess-before-selecting-backend-code-hook 
'(org-beamer-select-beamer-code)
org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc
org-beamer-auto-fragile-frames
org-beamer-place-default-actions-for-lists)
org-metadown-hook '(org-babel-pop-to-session-maybe)
org-export-blocks '((src org-babel-exp-src-blocks nil)
(comment org-export-blocks-format-comment t)
(ditaa org-export-blocks-format-ditaa nil)
(dot org-export-blocks-format-dot nil))
)

-- 

Christian Moe
E-mail:  mail@christianmoe.com
Website: http://christianmoe.com



-- 

Christian Moe
E-mail:  mail@christianmoe.com
Website: http://christianmoe.com

[PATCH] Use correct variable when calculating `org-timer-start-time'

[David Maus]

* org-timer.el (org-timer-start): Use correct variable when
calculating `org-timer-start-time'.
---
 lisp/org-timer.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org-timer.el b/lisp/org-timer.el
index e0817c8..3b3ef02 100644
--- a/lisp/org-timer.el
+++ b/lisp/org-timer.el
@@ -102,7 +102,7 @@ the region 0:00:00."
 	  (setq delta (org-timer-hms-to-secs (org-timer-fix-incomplete s)))))
 	(setq org-timer-start-time
 	      (seconds-to-time
-	       (- (org-float-time) (org-timer-hms-to-secs s)))))
+	       (- (org-float-time) delta))))
       (org-timer-set-mode-line 'on)
       (message "Timer start time set to %s, current value is %s"
 	       (format-time-string "%T" org-timer-start-time)
-- 
1.7.1

Re: [PATCH] Use correct variable when calculating `org-timer-start-time'

[Christian Moe]

Hi,

I've tested and this patch solves the bug I reported yesterday under the 
heading "[Orgmode] Bug: org-timer-start with offset [6.36trans]".

Thanks!

Yours,
Christian


David Maus wrote:
> * org-timer.el (org-timer-start): Use correct variable when
> calculating `org-timer-start-time'.
> ---
>  lisp/org-timer.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org-timer.el b/lisp/org-timer.el
> index e0817c8..3b3ef02 100644
> --- a/lisp/org-timer.el
> +++ b/lisp/org-timer.el
> @@ -102,7 +102,7 @@ the region 0:00:00."
>  	  (setq delta (org-timer-hms-to-secs (org-timer-fix-incomplete s)))))
>  	(setq org-timer-start-time
>  	      (seconds-to-time
> -	       (- (org-float-time) (org-timer-hms-to-secs s)))))
> +	       (- (org-float-time) delta))))
>        (org-timer-set-mode-line 'on)
>        (message "Timer start time set to %s, current value is %s"
>  	       (format-time-string "%T" org-timer-start-time)


-- 

Christian Moe
E-mail:  mail@christianmoe.com
Website: http://christianmoe.com

Re: Bug: org-timer-start with offset [6.36trans]

[Christian Moe]

Solved by David Maus's patch.

Thanks,
Christian

Patchwork: Patch 145 Accepted

[Carsten Dominik]

Patch 145 (http://patchwork.newartisans.com/patch/145/) is now Accepted.

This relates to the following submission:

http://mid.gmane.org/%3C1279347713-29950-1-git-send-email-dmaus%40ictsoc.de%3E