From: Bernhard Herzog <bernhard.herzog@intevation.de>
To: 6618@debbugs.gnu.org
Subject: bug#6618: Bug was probably introduced by revision 100788
Date: Tue, 13 Jul 2010 12:39:08 +0200 [thread overview]
Message-ID: <201007131239.08209.bernhard.herzog@intevation.de> (raw)
In-Reply-To: <8170-Mon12Jul2010120144+0100-jpff@codemist.co.uk>
I'm running into the same problem and I've debugged it a little. AFAICT the
problem was introduced with revision 100788. The revision immediately before
that works fine, but I can observer the problem with revision 100788. The
ChangeLog entry for this is
2010-07-12 Kenichi Handa <handa@m17n.org>
* font.h (enum font_property_index): New member FONT_ENTITY_INDEX.
* font.c (font_open_entity): Record ENTITY in FONT_OBJECT's slot
of FONT_ENTITY_INDEX.
(Ffont_get): If KEY is :otf and the font-object doesn't have the
property, get the property value dynamically.
(Ffont_put): Accept font-entity and font-object too.
(Ffont_get_glyhphs): Renamed from Fget_font_glyphs. Arguments and
return value changed.
(syms_of_font): Adjusted for the above change.
It's most likely the first change in font.c: "Record ENTITY in FONT_OBJECT's
slot of FONT_ENTITY_INDEX.":
--- src/font.c 2010-07-11 10:31:10 +0000
+++ src/font.c 2010-07-12 02:28:50 +0000
@@ -3005,7 +3005,7 @@
return Qnil;
ASET (entity, FONT_OBJLIST_INDEX,
Fcons (font_object, AREF (entity, FONT_OBJLIST_INDEX)));
- ASET (font_object, FONT_OBJLIST_INDEX, Qnil);
+ ASET (font_object, FONT_ENTITY_INDEX, entity);
num_fonts++;
font = XFONT_OBJECT (font_object);
This introduces circular references: font_object now refers to entity and
entity refers back to font_object. This probably leads to the stack overflow
in equal later on. A backtrace in gdb looks like this, after about 200
recursive calls of internal_equal:
#200 0x081a2012 in internal_equal (o1=<value optimized out>, o2=149618949,
depth=<value optimized out>, props=0) at fns.c:2127
#201 0x081a2012 in internal_equal (o1=<value optimized out>, o2=149761965,
depth=<value optimized out>, props=0) at fns.c:2127
#202 0x081a21ba in Fequal (o1=141309301, o2=149761965) at fns.c:2015
#203 0x080ddd67 in Finternal_set_lisp_face_attribute (face=138409674,
attr=138389402, value=149761965, frame=150016069) at xfaces.c:3288
Bernhard
next prev parent reply other threads:[~2010-07-13 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 11:01 bug#6618: 24.0.50; stack overflow in equal john ffitch
2010-07-13 10:39 ` Bernhard Herzog [this message]
2010-07-14 4:01 ` bug#6618: Bug was probably introduced by revision 100788 Kenichi Handa
2010-07-16 8:38 ` bug#6618: 24.0.50; stack overflow in equal john ffitch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007131239.08209.bernhard.herzog@intevation.de \
--to=bernhard.herzog@intevation.de \
--cc=6618@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.