From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Joe Brenner Newsgroups: gmane.emacs.bugs Subject: bug#6037: 24.0.50; menu-bar-mode function doesn't toggle Date: Mon, 26 Apr 2010 10:41:19 -0700 Message-ID: <201004261741.o3QHfJq8040081@kzsu.stanford.edu> References: <87r5m2vf28.fsf@kzsu.stanford.edu> NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1272307112 3725 80.91.229.12 (26 Apr 2010 18:38:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 26 Apr 2010 18:38:32 +0000 (UTC) Cc: 6037@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 26 20:38:26 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O6TCM-0001K2-5s for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Apr 2010 20:38:26 +0200 Original-Received: from localhost ([127.0.0.1]:48260 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6TCL-0004mH-C8 for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Apr 2010 14:38:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O6Szz-0007kZ-0l for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2010 14:25:39 -0400 Original-Received: from [140.186.70.92] (port=42694 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6Szw-0007gj-JB for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2010 14:25:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O6Szu-0003SP-MW for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2010 14:25:36 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35797) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6Szu-0003SK-Ku for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2010 14:25:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1O6SYI-00024M-AY; Mon, 26 Apr 2010 13:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joe Brenner Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Apr 2010 17:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6037-submit@debbugs.gnu.org id=B6037.12723045757938 (code B ref 6037); Mon, 26 Apr 2010 17:57:02 +0000 Original-Received: (at 6037) by debbugs.gnu.org; 26 Apr 2010 17:56:15 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6SXW-00023z-RD for submit@debbugs.gnu.org; Mon, 26 Apr 2010 13:56:15 -0400 Original-Received: from smtp2.stanford.edu ([171.67.219.82] helo=smtp.stanford.edu) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6SJG-0001vo-GW for 6037@debbugs.gnu.org; Mon, 26 Apr 2010 13:41:31 -0400 Original-Received: from smtp.stanford.edu (localhost.localdomain [127.0.0.1]) by localhost (Postfix) with SMTP id 8FC96170BD9; Mon, 26 Apr 2010 10:41:25 -0700 (PDT) Original-Received: from kzsu.stanford.edu (KZSU.Stanford.EDU [171.66.118.90]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.stanford.edu (Postfix) with ESMTPS id DD4921707DF; Mon, 26 Apr 2010 10:41:24 -0700 (PDT) Original-Received: from kzsu.stanford.edu (localhost.stanford.edu [127.0.0.1]) by kzsu.stanford.edu (8.13.4/8.13.7) with ESMTP id o3QHfJq8040081; Mon, 26 Apr 2010 10:41:24 -0700 (PDT) (envelope-from doom@kzsu.stanford.edu) In-reply-to: Comments: In-reply-to Stefan Monnier message dated "Mon, 26 Apr 2010 09:42:00 -0400." X-Mailer: MH-E 8.1; nmh 1.2; GNU Emacs 23.1.50 X-Scanned-By: MIMEDefang 2.56 on 171.66.118.47 X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-2.0.2 (kzsu.stanford.edu [127.0.0.1]); Mon, 26 Apr 2010 10:41:24 -0700 (PDT) X-Mailman-Approved-At: Mon, 26 Apr 2010 13:56:13 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 26 Apr 2010 13:57:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:36530 Archived-At: Stefan Monnier wrote: > > The menu-bar-mode function is not working as a toggle. > > See etc/NEWS. So I gather you're referring to this: * Incompatible Lisp Changes in Emacs 24.1 ** Test for special mode-class was moved from view-file to view-buffer. ** Passing a nil argument to a minor mode function now turns the mode ON unconditionally. You're of the opinion that using "nil" to turn on a minor-mode is actually correct behavior? And the important justification for breaking long-standing behavior was... ? > If you really want to toggle (I've never seen such a case from Elisp), > just do (menu-bar-mode 'toggle). Okay, thanks for the hint. Is that documented anywhere? If you'd like a use-case in elisp, I've been doing this in some form of or another for quite some time: ;------------ ; luddite mode (tool-bar-mode -1) (global-set-key [f12] '(lambda () (interactive) (menu-bar-mode -1) (scroll-bar-mode) (setq use-dialog-box nil) )) > > Note that running scroll-bar-mode repeatedly does work as a toggle, as > > expected for menu-bar-mode: > > (scroll-bar-mode) > > Yes, that's a bug that I hope to fix before Emacs-24. > I.e. better not rely on it. Allow me to quote the documentation for menu-bar-mode: "Toggle display of a menu bar on each frame." And again for scroll-bar-mode: "Toggle display of vertical scroll bars on all frames."