From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: log-edit-strip-single-file-name Date: Fri, 5 Feb 2010 20:26:22 -0800 (PST) Message-ID: <201002060426.o164QMaa000423@godzilla.ics.uci.edu> References: <3a26oiti.fsf@fencepost.gnu.org> <12bpggw4wg.fsf@fencepost.gnu.org> <201001290820.o0T8KCv1022959@godzilla.ics.uci.edu> <201002040751.o147pVEb025009@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1265430498 8184 80.91.229.12 (6 Feb 2010 04:28:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Feb 2010 04:28:18 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 06 05:28:14 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NdcHD-0006hB-EG for ged-emacs-devel@m.gmane.org; Sat, 06 Feb 2010 05:28:11 +0100 Original-Received: from localhost ([127.0.0.1]:53383 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NdcHA-0008Ev-AW for ged-emacs-devel@m.gmane.org; Fri, 05 Feb 2010 23:28:08 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NdcH5-0008EC-KY for emacs-devel@gnu.org; Fri, 05 Feb 2010 23:28:03 -0500 Original-Received: from [199.232.76.173] (port=45165 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NdcH5-0008E4-9g for emacs-devel@gnu.org; Fri, 05 Feb 2010 23:28:03 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NdcH3-0004K9-PL for emacs-devel@gnu.org; Fri, 05 Feb 2010 23:28:02 -0500 Original-Received: from paul-mcgann-v0.ics.uci.edu ([128.195.1.147]:40351) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NdcH3-00043d-3T for emacs-devel@gnu.org; Fri, 05 Feb 2010 23:28:01 -0500 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o164QM8a032372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 5 Feb 2010 20:26:22 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o164QMaa000423; Fri, 5 Feb 2010 20:26:22 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Thu, 04 Feb 2010 10:40:31 -0500") Original-Lines: 16 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o164QM8a032372 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:120971 Archived-At: Stefan Monnier writes: > > (the code that sets the local variables in > > hack-dir-local-variables-non-file-buffer should be put in a function > > that is also called from hack-local-variables). > > Yes, that would make sense. > > > - (let ((variables-file (dir-locals-find-file (buffer-file-name))) > > + (let ((variables-file (dir-locals-find-file (or dname (buffer-file-name)))) > > Why (or dname (buffer-file-name)) rather than (or buffer-file-name default-directory)? It looked clearer to me. Can this patch go in?