From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#5456: vc-hg-state does not search hg in vc-path Date: Sun, 24 Jan 2010 22:16:29 -0800 (PST) Message-ID: <201001250616.o0P6GThb002574@godzilla.ics.uci.edu> References: <26BBB3D3-37BA-4E83-A9C3-16247D4D8241@sun.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1264401764 15715 80.91.229.12 (25 Jan 2010 06:42:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 Jan 2010 06:42:44 +0000 (UTC) Cc: 5456@debbugs.gnu.org To: Stephan Bergmann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 25 07:42:36 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NZIeg-0000wx-DO for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Jan 2010 07:42:34 +0100 Original-Received: from localhost ([127.0.0.1]:39561 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZIeh-0008BA-Kn for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Jan 2010 01:42:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZIc3-0007jw-5j for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2010 01:39:51 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZIby-0007il-Gf for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2010 01:39:50 -0500 Original-Received: from [199.232.76.173] (port=58568 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZIby-0007if-3a for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2010 01:39:46 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39133) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NZIbx-0004gV-Pq for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2010 01:39:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NZIFy-0005Nm-IF; Mon, 25 Jan 2010 01:17:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Jan 2010 06:17:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5456 X-Emacs-PR-Package: emacs,vc X-Emacs-PR-Keywords: patch Original-Received: via spool by 5456-submit@debbugs.gnu.org id=B5456.126440020420677 (code B ref 5456); Mon, 25 Jan 2010 06:17:02 +0000 Original-Received: (at 5456) by debbugs.gnu.org; 25 Jan 2010 06:16:44 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZIFg-0005NR-3W for submit@debbugs.gnu.org; Mon, 25 Jan 2010 01:16:44 -0500 Original-Received: from paul-mcgann-v0.ics.uci.edu ([128.195.1.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZIFe-0005NM-Dc for 5456@debbugs.gnu.org; Mon, 25 Jan 2010 01:16:43 -0500 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o0P6GT1G025326 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 24 Jan 2010 22:16:30 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o0P6GThb002574; Sun, 24 Jan 2010 22:16:29 -0800 (PST) In-Reply-To: <26BBB3D3-37BA-4E83-A9C3-16247D4D8241@sun.com> (Stephan Bergmann's message of "Fri, 22 Jan 2010 23:05:58 +0100") Original-Lines: 35 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o0P6GT1G025326 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -2.6 (--) Resent-Date: Mon, 25 Jan 2010 01:17:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34696 Archived-At: Stephan Bergmann writes: > At least in 23.1, vc-hg-state (and vc-hg-working-revision) in vc-hg.el call "hg" without making sure that it is being searched for in vc-path (as is done in vc-dispatcher.el by extending exec-path). What fixed it for me (on recent trunk) is > ---8<--- > === modified file 'lisp/vc-hg.el' > --- lisp/vc-hg.el 2010-01-13 08:35:10 +0000 > +++ lisp/vc-hg.el 2010-01-22 21:46:14 +0000 > @@ -169,7 +169,8 @@ > ;; Ignore all errors. > (let ((process-environment > ;; Avoid localization of messages so we can parse the output. > - (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment))) > + (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment)) > + (exec-path (append vc-path exec-path))) > > (process-file > "hg" nil t nil > @@ -205,7 +206,8 @@ > (let ((process-environment > ;; Avoid localization of messages so we can parse the output. > (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") > - process-environment))) > + process-environment)) > + (exec-path (append vc-path exec-path))) > ;; Ignore all errors. > (process-file > "hg" nil t nil There's more places where a change like this would be necessary.... Actually, looking over all the VC backends, almost all could use vc-path, but NONE does. So I'd rather vote for deprecating vc-path in 23.2 and remove it later.