From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Lillibridge Newsgroups: gmane.emacs.bugs Subject: bug#5042: 23.1; linum-mode gives incorrect line numbers with narrowed buffers Date: Sat, 23 Jan 2010 15:28:21 -0800 Message-ID: <201001232328.o0NNSL55029058@mailhub-pa1.hpl.hp.com> References: <200911260039.nAQ0dTD1019384@mailhub-pa1.hpl.hp.com> <200912100534.nBA5YSva008256@mailhub-pa1.hpl.hp.com> <200912210659.nBL6xhDG020940@mailhub-pa1.hpl.hp.com> <201001070538.o075cpux020583@mailhub-pa1.hpl.hp.com> <201001100132.o0A1WIxG005631@mailhub-pa1.hpl.hp.com> <201001162208.o0GM8Apr008065@mailhub-pa1.hpl.hp.com> NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1264290149 28821 80.91.229.12 (23 Jan 2010 23:42:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Jan 2010 23:42:29 +0000 (UTC) Cc: 5042@emacsbugs.donarmstrong.com, markus.triska@gmx.at To: lekktu@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 24 00:42:21 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NYpb7-0005zD-EY for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Jan 2010 00:40:57 +0100 Original-Received: from localhost ([127.0.0.1]:35878 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NYpb8-0005IS-K8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Jan 2010 18:40:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NYpZy-0004xf-PF for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2010 18:39:46 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NYpZu-0004tc-PP for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2010 18:39:46 -0500 Original-Received: from [199.232.76.173] (port=60166 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NYpZu-0004tQ-LG for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2010 18:39:42 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52970) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NYpZu-0003Mj-6q for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2010 18:39:42 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NYpPa-0005Hu-3Z; Sat, 23 Jan 2010 18:29:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Mark Lillibridge Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jan 2010 23:29:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5042 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5042-submit@debbugs.gnu.org id=B5042.126428931520320 (code B ref 5042); Sat, 23 Jan 2010 23:29:02 +0000 Original-Received: (at 5042) by debbugs.gnu.org; 23 Jan 2010 23:28:35 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYpP8-0005Hh-ML for submit@debbugs.gnu.org; Sat, 23 Jan 2010 18:28:34 -0500 Original-Received: from gundega.hpl.hp.com ([192.6.19.190]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NYpP6-0005Ha-Qm for 5042@emacsbugs.donarmstrong.com; Sat, 23 Jan 2010 18:28:33 -0500 Original-Received: from mailhub-pa1.hpl.hp.com (mailhub-pa1.hpl.hp.com [15.25.115.25]) by gundega.hpl.hp.com (8.14.3/8.14.1/HPL-PA Relay) with ESMTP id o0NNSNl5010425 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 23 Jan 2010 15:28:23 -0800 (PST) Original-Received: from ts-rhel4.hpl.hp.com (ts-rhel4.hpl.hp.com [15.25.118.24]) by mailhub-pa1.hpl.hp.com (8.14.3/8.14.3/HPL-PA Hub) with ESMTP id o0NNSL55029058; Sat, 23 Jan 2010 15:28:21 -0800 In-reply-to: (message from Juanma Barranquero on Sun, 17 Jan 2010 00:03:34 +0100) X-MailScanner-ID: o0NNSNl5010425 X-HPL-MailScanner: Found to be clean X-HPL-MailScanner-From: mark.lillibridge@hp.com X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -3.4 (---) Resent-Date: Sat, 23 Jan 2010 18:29:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34669 Archived-At: Ok, I have pulled the source code from the CVS repository and I'm starting to work on the new feature/bug fix. We are creating a new variable that determines whether or not to restart numbering lines at the start of a restriction. I suggest calling this "restart-numbering-restriction" with possible values t and nil (=false). Is this naming convention/description okay? Second, this should clearly be a customizable variable, thus created with defcustom in some group. The question is, which group? Some quick browsing with M-x customize suggests the reasonable possibilities are: emacs > convenience > Linum "Show line numbers in the left margin." emacs > editing > editing basics group "most basic editing facilities." The first group here really seems to only be for Linum features, which this is not. It does look like a reasonable place a a user might search/discover this option. I'm not sure if I can declare a variable in that group without actually requiring Linum to be loaded first. What do people think? - Mark (defcustum restart-numbering-restriction nil "How should the lines of a restriction be numbered? Normally, they receive the same line numbers as if no restriction existed (e.g., if the first line of the restriction is line number 10 of the file then it receives line number 10. If this variable is true, the lines of the restriction are instead numbered from 1." :group ??? :type '(boolean))