From: Dan Nicolaescu <dann@ics.uci.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ulm@gentoo.org, emacs-devel@gnu.org
Subject: Re: colours in client on xterm (if an X frame is open at same time)
Date: Sun, 10 Jan 2010 00:49:53 -0800 (PST) [thread overview]
Message-ID: <201001100849.o0A8nrDE009786@godzilla.ics.uci.edu> (raw)
In-Reply-To: <838wc7af0e.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Jan 2010 09:55:45 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> > Date: Fri, 8 Jan 2010 20:18:58 -0800 (PST)
> > From: Dan Nicolaescu <dann@ics.uci.edu>
> > Cc: emacs-devel@gnu.org
> >
> > > In your case the only effect that patch should have is to move the call
> > > (tty-set-up-initial-frame-faces) from before
> > >
> > > (let ((coding-system-for-read 'binary)
> > >
> > > to after it.
> >
> > If I put back the `tty-set-up-initial-frame-faces' call (after
> > `xterm-register-default-colors') and make current
> > `tty-set-up-initial-frame-faces' conditional on detecting a dark
> > background, then everything seems to work OK.
> >
> > Calling `tty-set-up-initial-frame-faces' twice in the dark background
> > case is very ugly, but in case nobody finds a better solution soon I'll
> > check in that change soon.
>
> I wasn't following this thread. I don't know if I can help, but
> there's something I don't understand: is it the case that the new code
> mis-computes the background reported by xterm? That is, it sets up
> for a dark background when it is in fact light?
No, the background mode is computed just fine, and it's light (the
default for xterm anyway).
> Or is the background mode computed correctly, but the call to
> tty-set-up-initial-frame-faces in its new location does not do what
> it's expected to do?
>
> If the latter, then I'd step through tty-set-up-initial-frame-faces to
> see what goes wrong there. I see that it calls
> frame-set-background-mode, so perhaps the problem is within that
> function.
In the case where everything works correctly (before the patch),
when stepping through frame-set-background-mode (called by
tty-set-up-initial-frame-faces) the default face gets set up wrong.
So debugging hurts in this case :-(
next prev parent reply other threads:[~2010-01-10 8:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 23:26 colours in client on xterm (if an X frame is open at same time) Ulrich Mueller
2010-01-07 23:58 ` Dan Nicolaescu
2010-01-08 6:43 ` Ulrich Mueller
2010-01-08 7:13 ` Dan Nicolaescu
2010-01-08 16:29 ` Ulrich Mueller
2010-01-08 18:28 ` Dan Nicolaescu
2010-01-08 22:31 ` Ulrich Mueller
[not found] ` <201001090418.o094Iw6d007997@godzilla.ics.uci.edu>
2010-01-09 7:55 ` Eli Zaretskii
2010-01-10 8:49 ` Dan Nicolaescu [this message]
2010-01-10 18:03 ` Eli Zaretskii
2010-01-10 18:32 ` Dan Nicolaescu
2010-01-08 7:47 ` Jan Djärv
2010-01-08 16:48 ` Dan Nicolaescu
2010-01-08 3:02 ` Eric Hanchrow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001100849.o0A8nrDE009786@godzilla.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.