From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: colours in client on xterm (if an X frame is open at same time) Date: Fri, 8 Jan 2010 10:28:35 -0800 (PST) Message-ID: <201001081828.o08ISZgT016268@godzilla.ics.uci.edu> References: <19270.28051.401596.689093@a1i15.kph.uni-mainz.de> <201001072358.o07NwL1e006325@godzilla.ics.uci.edu> <19270.54295.87807.81836@a1i15.kph.uni-mainz.de> <201001080713.o087DpNv021759@godzilla.ics.uci.edu> <19271.23938.742044.640825@a1i15.kph.uni-mainz.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1262975517 6714 80.91.229.12 (8 Jan 2010 18:31:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Jan 2010 18:31:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ulrich Mueller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 08 19:31:50 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NTJci-0001wD-KI for ged-emacs-devel@m.gmane.org; Fri, 08 Jan 2010 19:31:48 +0100 Original-Received: from localhost ([127.0.0.1]:51970 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NTJcj-0003aV-62 for ged-emacs-devel@m.gmane.org; Fri, 08 Jan 2010 13:31:49 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NTJbK-0002lX-Vp for emacs-devel@gnu.org; Fri, 08 Jan 2010 13:30:23 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NTJbF-0002gt-Pk for emacs-devel@gnu.org; Fri, 08 Jan 2010 13:30:22 -0500 Original-Received: from [199.232.76.173] (port=55256 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NTJbF-0002gk-Fm for emacs-devel@gnu.org; Fri, 08 Jan 2010 13:30:17 -0500 Original-Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]:48369) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NTJbE-0001tY-Rn for emacs-devel@gnu.org; Fri, 08 Jan 2010 13:30:17 -0500 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o08ISZpB017038 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 8 Jan 2010 10:28:35 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o08ISZgT016268; Fri, 8 Jan 2010 10:28:35 -0800 (PST) In-Reply-To: <19271.23938.742044.640825@a1i15.kph.uni-mainz.de> (Ulrich Mueller's message of "Fri, 8 Jan 2010 17:29:54 +0100") Original-Lines: 61 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o08ISZpB017038 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:119722 Archived-At: Ulrich Mueller writes: > >>>>> On Thu, 7 Jan 2010, Dan Nicolaescu wrote: > > >> Anyway, my point was, why are the colours _different_ in the second > >> case? Especially, why is the background grey? > > > It should not be. I can't reproduce it here, but by emacs is about > > 2 weeks old. > > > In the grey case, do you get something odd if you do a describe-face > > for the default face? > > Differences between normal and grey case are: > > - Foreground: unspecified-fg > - Background: unspecified-bg > + Foreground: black > + Background: white > > - Font: unspecified > - Fontset: nil > + Font: # > + Fontset: -unknown-DejaVu Sans Mono-normal-normal-normal-*-13-*-*-*-m-0-fontset-startup > > > Is this something new? Do you get the same behavior with 23.1? > > If not, then doing a binary search for the patch that broke it is your > > best bet... > > I had hoped that the bisecting could be avoided, but here we go. > > The "grey background" started with revision 99013 (and reverting this > changeset in the trunk of today brings back the old behaviour): > > revno: 99013 > committer: Dan Nicolaescu > branch nick: trunk > timestamp: Mon 2009-12-07 06:30:30 +0000 > message: > Get the background mode from the terminal for xterm, and set > faces accordingly. > * term/xterm.el (xterm-set-background-mode): New function. > (terminal-init-xterm): Use it in case xterm supports background > color queries. Recompute faces after getting the background > color. Thanks. In your case the only effect that patch should have is to move the call (tty-set-up-initial-frame-faces) from before (let ((coding-system-for-read 'binary) to after it. What happens in that `let' should not matter to your setup because your background is light, so change 99013 should be a no-op in your case. Hmmm, this is very odd...