From: Dan Nicolaescu <dann@ics.uci.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Juanma Barranquero <lekktu@gmail.com>,
Chong Yidong <cyd@stupidchicken.com>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: bug#881: patch for bug #881
Date: Wed, 6 Jan 2010 10:29:00 -0800 (PST) [thread overview]
Message-ID: <201001061829.o06IT0Zm002189@godzilla.ics.uci.edu> (raw)
In-Reply-To: <jwviqbfgw6f.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 06 Jan 2010 09:20:04 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> > How should it work? We don't have any nice generic mechanism/UI for
> > doing VC backend specific things in the commit buffer.
>
> It's a general concept, although it's not supported by all backends.
The general concept is that backends want to do backend specific things :-)
For example git might want to add "--signoff"
Or might want to add "--amend", in which case the log for the latest
commit should be inserted in the log-edit buffer for further editing.
> I'd imagine some log-edit-mode command that set log-edit-author and is
> then somehow passed to VC via the log-edit-callback which then passes it
> to the backend as an additional argument to the `commit' operation.
>
> Maybe the easiest way is to store the info directly in the text in the
> form of a "Author: ..." line somewhere.
>
> Along similar lines, we'd like a way to pass the "--fixes" arg to Bzr,
> so maybe we should let log-edit-mode use a buffer in a RFC822-like format,
> where backends may recognize some headers ("Subject", "Author",
> "Fixes", ...) and discard others.
This would be helpful, but not enough, we also want to have some key
bindings, menu entries for backend specific things.
So how about starting by replacing the call to `log-edit' in
`vc-log-edit' with (vc-call-backend backend 'log-edit)
and then each backend that so desires can implement a mode derived from
log-edit and do whatever it wants (like we do for log-view).
next prev parent reply other threads:[~2010-01-06 18:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 22:11 bug#881: patch for bug #881 Chong Yidong
2010-01-06 0:43 ` Juanma Barranquero
2010-01-06 3:35 ` Karl Fogel
2010-01-06 4:12 ` Juanma Barranquero
2010-01-06 4:19 ` Karl Fogel
2010-01-06 10:12 ` Juanma Barranquero
2010-01-06 18:15 ` Eli Zaretskii
2010-01-06 20:43 ` Juanma Barranquero
2010-01-07 4:14 ` Eli Zaretskii
2010-01-07 9:13 ` Juanma Barranquero
2010-01-06 4:13 ` Eli Zaretskii
2010-01-06 4:34 ` Stefan Monnier
2010-01-06 7:00 ` Dan Nicolaescu
2010-01-06 7:22 ` Óscar Fuentes
2010-01-06 9:34 ` Stephen J. Turnbull
2010-01-06 14:20 ` Stefan Monnier
2010-01-06 18:29 ` Dan Nicolaescu [this message]
2010-01-06 20:19 ` Stefan Monnier
2010-01-07 17:09 ` Dan Nicolaescu
2010-01-07 20:07 ` Stefan Monnier
2010-01-06 18:29 ` Eli Zaretskii
2010-01-06 18:52 ` Óscar Fuentes
2010-01-06 20:20 ` Stefan Monnier
2010-01-06 20:40 ` Eli Zaretskii
2010-01-07 15:33 ` Juanma Barranquero
2010-01-07 17:15 ` bzr --fixes [was Re: bug#881: patch for bug #881] Glenn Morris
2010-01-07 20:12 ` Juanma Barranquero
2010-01-07 20:34 ` bzr --fixes Glenn Morris
2010-01-07 22:35 ` Juanma Barranquero
2010-01-08 9:01 ` Eli Zaretskii
2010-01-08 8:27 ` Eli Zaretskii
2010-01-06 20:00 ` Committing other people's changes (was: bug#881: patch for bug #881) Reiner Steib
2010-01-16 21:50 ` bug#881: patch for bug #881 Chong Yidong
2010-01-16 21:52 ` Juanma Barranquero
2010-01-16 22:30 ` Chong Yidong
2010-01-17 9:38 ` Dan Nicolaescu
-- strict thread matches above, loose matches on Subject: below --
2010-01-05 1:21 Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001061829.o06IT0Zm002189@godzilla.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.