From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: support for bzr shelve/unshelve in vc-dir Date: Fri, 18 Dec 2009 07:39:59 -0800 (PST) Message-ID: <200912181539.nBIFdxDB017165@godzilla.ics.uci.edu> References: <200912011947.nB1JlaAp027561@godzilla.ics.uci.edu> <200912032257.nB3Mv97m029382@godzilla.ics.uci.edu> <87d42vvabf.fsf@uwakimon.sk.tsukuba.ac.jp> <200912040147.nB41ldTH000836@godzilla.ics.uci.edu> <87hbs7zbs2.fsf@telefonica.net> <200912042118.nB4LIS4j009931@godzilla.ics.uci.edu> <878wdiz9hz.fsf@telefonica.net> <200912101402.nBAE2wnW011990@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1261151359 4560 80.91.229.12 (18 Dec 2009 15:49:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Dec 2009 15:49:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: Martin Pool Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 18 16:49:06 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NLf4j-0003AG-Cb for ged-emacs-devel@m.gmane.org; Fri, 18 Dec 2009 16:49:05 +0100 Original-Received: from localhost ([127.0.0.1]:55214 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NLf4j-0004d6-5l for ged-emacs-devel@m.gmane.org; Fri, 18 Dec 2009 10:49:05 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NLexd-0007qo-Q9 for emacs-devel@gnu.org; Fri, 18 Dec 2009 10:41:45 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NLexY-0007ma-Qa for emacs-devel@gnu.org; Fri, 18 Dec 2009 10:41:45 -0500 Original-Received: from [199.232.76.173] (port=59918 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NLexY-0007mS-Dw for emacs-devel@gnu.org; Fri, 18 Dec 2009 10:41:40 -0500 Original-Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]:48328) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NLexX-0007Ww-Uz for emacs-devel@gnu.org; Fri, 18 Dec 2009 10:41:40 -0500 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nBIFe0xq016964 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 18 Dec 2009 07:40:00 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nBIFdxDB017165; Fri, 18 Dec 2009 07:39:59 -0800 (PST) In-Reply-To: (Martin Pool's message of "Fri, 11 Dec 2009 15:02:51 +1100") Original-Lines: 39 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nBIFe0xq016964 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_BZ 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118714 Archived-At: Martin Pool writes: > 2009/12/11 Dan Nicolaescu : > > This discussion started in part because of the perceived difficulty of > > getting a patch integrated to implement "bzr unshelve --keep" > > (https://bugs.launchpad.net/bzr/+bug/492091) >=20 > I would be the first to agree that we have made it too hard to get > changes in in the past, and that while we are doing better now we can > still do more. However, I can't find any history with this particular > request, just a recently-filed bug? I don't think that's the whole history here. > > bzr shelves are not very usable without this option, you can't go back > > and forth between shelved versions. > > The patch would change bzrlib/shelf_ui.py:Unshelver.from_args to set > > delete_shelf to False when "--keep" is passed. =C2=A0So about 3 lines= total. > > > > Would such a patch need copyright assignment? > > Even if it does, given the above description, a bzr developer can > > reproduce the change needed in a few seconds... > > Can you please help get this solved? >=20 > Yes, it would need copyright assignment. We do this on every patch > because our legal opinion said that there is no globally-recognized > concept of "too small to copyright", and because we want to have clear > copyright. Many developers, both at Canonical and otherwise, have > given feedback that they think the FSF approach of saying "about a > paragraph" (or whatever it precisely is) is a reasonable commonsense > tradeoff.. FYI: the FSF policy is to require a copyright assignment from someone that submits a number of small patches, so it's not possible to work around the copyright requirement by splitting a larger change into many smaller ones. It looks like bzr unshelve --keep will make it into the next version, thanks for taking care of it!