all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 5211@emacsbugs.donarmstrong.com
Subject: bug#5211: Color escape codes in the output of vc-git-print-log
Date: Tue, 15 Dec 2009 06:57:30 -0800 (PST)	[thread overview]
Message-ID: <200912151457.nBFEvUT3007406@godzilla.ics.uci.edu> (raw)
In-Reply-To: <f7ccd24b0912140812jfe0104ek67d91233840138a7@mail.gmail.com> (Juanma Barranquero's message of "Mon, 14 Dec 2009 17:12:24 +0100")

Juanma Barranquero <lekktu@gmail.com> writes:

  > Package: emacs,vc
  > Tags: patch
  > Version: 23.1.90
  > Severity: minor
  > 
  > 
  > Depending of your setting of color.diff, color is used for log output,
  > and vc-print-log shows garbage (OK, escape codes for color):
  > 
  > ^[[33mcommit 43a3bf88e5e495ad048b3a6d3cf852e1e7a02f1c^[[m
  > Author: xxx <yyy@zzz>
  > Date:   2009-12-14 17:11:35 +0200
  > 
  >     blah blah blah
  > 
  > 
  > As color in *vc-change-log* buffers is an issue for font-locking, and
  > not for git log, the command should be called with --no-color.
  > 
  > OK to the following patch?
  > 
  >     Juanma
  > 
  > 
  > 2009-12-14  Juanma Barranquero  <lekktu@gmail.com>
  > 
  > 	* vc-git.el (vc-git-print-log): Pass --no-color to `git log'.

When did the --no-color option appear?
If we pass it by default, then it will break C-x v l for git versions
that do not support it.
If --no-color is old enough, the it might not matter...





  parent reply	other threads:[~2009-12-15 14:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f7ccd24b0912271847j7f282733y358910002b582b49@mail.gmail.com>
2009-12-14 16:12 ` bug#5211: Color escape codes in the output of vc-git-print-log Juanma Barranquero
2009-12-15  4:27   ` Stefan Monnier
2009-12-15  4:31     ` Juanma Barranquero
2009-12-15  5:36       ` Eli Zaretskii
2009-12-15 11:15         ` Juanma Barranquero
2009-12-15 13:01           ` Eli Zaretskii
2009-12-15 13:09             ` Juanma Barranquero
2009-12-15 14:57   ` Dan Nicolaescu [this message]
2009-12-15 15:42     ` Juanma Barranquero
2009-12-15 18:32       ` Andreas Schwab
2009-12-15 18:36         ` Juanma Barranquero
2009-12-15 23:34           ` Andreas Schwab
2009-12-15 23:57             ` Juanma Barranquero
2009-12-28  2:49   ` bug#5211: marked as done (Color escape codes in the output of vc-git-print-log) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200912151457.nBFEvUT3007406@godzilla.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=5211@emacsbugs.donarmstrong.com \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.