all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Tom Tromey <tromey@redhat.com>
Cc: 4610@emacsbugs.donarmstrong.com
Subject: bug#4610: 23.1; VC commit buffer should list files to be committed
Date: Thu, 10 Dec 2009 11:54:53 -0800 (PST)	[thread overview]
Message-ID: <200912101954.nBAJsrFL014783@godzilla.ics.uci.edu> (raw)
In-Reply-To: <m3r5tmvme1.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu,  01 Oct 2009 15:23:50 -0600")

Tom Tromey <tromey@redhat.com> writes:

  > Today I accidentally committed one file but not another one from
  > *vc-dir*.  That happened because point was on one file, not on the
  > containing directory as I'd thought.
  > 
  > It would be nice if the VC commit message buffer listed the files that
  > were going to be committed.  Such a list should automatically be
  > stripped out before being sent to the underlying command as the commit
  > message.

The list of files to be committed can be seen by using `log-edit-show-files'.
log-edit-hook can be configured to do it automatically.

On the other hand is it clear that showing such a list by default helps?
My personal experience with perforce (where files are listed in the
commit message by default -- and the list is editable) shows that the
same mistake is quite possible (and not infrequent) there.  IMMV...





  reply	other threads:[~2009-12-10 19:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-01 21:23 bug#4610: 23.1; VC commit buffer should list files to be committed Tom Tromey
2009-12-10 19:54 ` Dan Nicolaescu [this message]
2021-07-18 18:50 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200912101954.nBAJsrFL014783@godzilla.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=4610@emacsbugs.donarmstrong.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.