From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: VC command for showing outgoing changes Date: Sat, 5 Dec 2009 11:45:36 -0800 (PST) Message-ID: <200912051945.nB5Jjam5020140@godzilla.ics.uci.edu> References: <200910132024.n9DKOHGj015040@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1260042452 23888 80.91.229.12 (5 Dec 2009 19:47:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Dec 2009 19:47:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 05 20:47:25 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NH0bF-0005fj-Du for ged-emacs-devel@m.gmane.org; Sat, 05 Dec 2009 20:47:25 +0100 Original-Received: from localhost ([127.0.0.1]:39560 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NH0bF-0007bp-8G for ged-emacs-devel@m.gmane.org; Sat, 05 Dec 2009 14:47:25 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NH0b9-0007aO-5z for emacs-devel@gnu.org; Sat, 05 Dec 2009 14:47:19 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NH0b4-0007VA-I4 for emacs-devel@gnu.org; Sat, 05 Dec 2009 14:47:18 -0500 Original-Received: from [199.232.76.173] (port=42054 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NH0b4-0007V1-Dm for emacs-devel@gnu.org; Sat, 05 Dec 2009 14:47:14 -0500 Original-Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]:58333) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NH0b3-0002JL-UW for emacs-devel@gnu.org; Sat, 05 Dec 2009 14:47:14 -0500 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nB5JjbUx027486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 5 Dec 2009 11:45:37 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nB5Jjam5020140; Sat, 5 Dec 2009 11:45:36 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Tue, 13 Oct 2009 16:52:18 -0400") Original-Lines: 34 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nB5JjbUx027486 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118316 Archived-At: Stefan Monnier writes: > > It would be nice to have a VC command for showing the outgoing changes > > for distributed VC systems (i.e. the log of the changes that will be > > pushed when you do a VC push). > > Let's call this method vc-outgoing (name suggestions are welcome). > > I think before that we should have support for a `push' backend operation. > > > vc-hg-outgoing does this, but it's only for mercurial, it would be good > > to have a generic method for doing such a thing. > > Agreed. > > > One thing we can do is to create a log-view-base-mode and have > > log-view-mode and log-view-outgoing-mode derive from this mode, and have > > log-view-mode and log-view-outgoing-mode define their own commands and > > key bindings. > > Since each backend typically creates its own vc--log-view-mode, > that tend to lead to the need for "multiple inheritance" in > define-derived-mode. Given the lack of support for such a monster right > now, we should probably stick to something simpler, e.g. add > a log-view-outgoing binary var, behaving kind of like a minor-mode and > controlling availability of some extra bindings. Here's a patch that implements the generic vc-incoming, vc-outgoing and implements the backend specific functions for bzr, hg and partially for git (no incoming and outgoing is not quite right). Showing diffs works. What keys should we use? C-x v I and C-x v O ? This will be useful when we switch to bzr... OK to check in?