From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Add a keybinding to vc-dir Date: Tue, 1 Dec 2009 11:39:46 -0800 (PST) Message-ID: <200912011939.nB1Jdkli027498@godzilla.ics.uci.edu> References: <874ooatrrb.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1259696512 30609 80.91.229.12 (1 Dec 2009 19:41:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Dec 2009 19:41:52 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 01 20:41:45 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NFYbX-00071a-A4 for ged-emacs-devel@m.gmane.org; Tue, 01 Dec 2009 20:41:43 +0100 Original-Received: from localhost ([127.0.0.1]:48362 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFYbW-0006B8-If for ged-emacs-devel@m.gmane.org; Tue, 01 Dec 2009 14:41:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFYbR-0006Aq-EV for emacs-devel@gnu.org; Tue, 01 Dec 2009 14:41:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFYbN-00068X-Su for emacs-devel@gnu.org; Tue, 01 Dec 2009 14:41:37 -0500 Original-Received: from [199.232.76.173] (port=56560 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFYbN-00068R-OR for emacs-devel@gnu.org; Tue, 01 Dec 2009 14:41:33 -0500 Original-Received: from paul-mcgann-v0.ics.uci.edu ([128.195.1.147]:44046) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NFYbN-0007rB-Cl for emacs-devel@gnu.org; Tue, 01 Dec 2009 14:41:33 -0500 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nB1Jdlna011971 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 1 Dec 2009 11:39:47 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nB1Jdkli027498; Tue, 1 Dec 2009 11:39:46 -0800 (PST) In-Reply-To: <874ooatrrb.fsf@stupidchicken.com> (Chong Yidong's message of "Tue, 01 Dec 2009 14:32:08 -0500") Original-Lines: 20 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nB1Jdlna011971 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118051 Archived-At: Chong Yidong writes: > In the VC log, the "d" key calls log-view-diff. > In VC-dir, the "=" key calls vc-diff (to match C-x v =). > > For mnemonic purposes, it might be good if log-view mode also binds "=" > to log-view-diff, and VC-dir binds "d" to vc-diff. > > Any objections? Please don't add "d" to vc-dir. d can be used for other things in vc-dir in the future, and = is already easy enough to type. > The only obvious problem with doing this is if you (or > others) plan to introduce more operations to vc-dir in the future, so > that we need to conserve scarce keys. That doesn't seem like an issue > to me, but thought I'd check in first.