all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Add a keybinding to vc-dir
@ 2009-12-01 19:32 Chong Yidong
  2009-12-01 19:39 ` Dan Nicolaescu
  0 siblings, 1 reply; 4+ messages in thread
From: Chong Yidong @ 2009-12-01 19:32 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: emacs-devel

In the VC log, the "d" key calls log-view-diff.
In VC-dir, the "=" key calls vc-diff (to match C-x v =).

For mnemonic purposes, it might be good if log-view mode also binds "="
to log-view-diff, and VC-dir binds "d" to vc-diff.

Any objections?  The only obvious problem with doing this is if you (or
others) plan to introduce more operations to vc-dir in the future, so
that we need to conserve scarce keys.  That doesn't seem like an issue
to me, but thought I'd check in first.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Add a keybinding to vc-dir
  2009-12-01 19:32 Add a keybinding to vc-dir Chong Yidong
@ 2009-12-01 19:39 ` Dan Nicolaescu
  2009-12-02  2:08   ` Miles Bader
  0 siblings, 1 reply; 4+ messages in thread
From: Dan Nicolaescu @ 2009-12-01 19:39 UTC (permalink / raw)
  To: Chong Yidong; +Cc: emacs-devel

Chong Yidong <cyd@stupidchicken.com> writes:

  > In the VC log, the "d" key calls log-view-diff.
  > In VC-dir, the "=" key calls vc-diff (to match C-x v =).
  > 
  > For mnemonic purposes, it might be good if log-view mode also binds "="
  > to log-view-diff, and VC-dir binds "d" to vc-diff.
  > 
  > Any objections?  

Please don't add "d" to vc-dir. 
d can be used for other things in vc-dir in the future, and = is already
easy enough to type.


  > The only obvious problem with doing this is if you (or
  > others) plan to introduce more operations to vc-dir in the future, so
  > that we need to conserve scarce keys.  That doesn't seem like an issue
  > to me, but thought I'd check in first.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Add a keybinding to vc-dir
  2009-12-01 19:39 ` Dan Nicolaescu
@ 2009-12-02  2:08   ` Miles Bader
  2009-12-02  3:04     ` RET binding in vc-annotate and log-view [was: Re: Add a keybinding to vc-dir] Dan Nicolaescu
  0 siblings, 1 reply; 4+ messages in thread
From: Miles Bader @ 2009-12-02  2:08 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: Chong Yidong, emacs-devel

Dan Nicolaescu <dann@ics.uci.edu> writes:
>  Please don't add "d" to vc-dir. 
>  d can be used for other things in vc-dir in the future, and = is already
>  easy enough to type.

Yeah, ... "=" seems the usual emacs thingie for diffing, so it seems
good to emphasize that.

-Miles

-- 
Optimist, n. A proponent of the doctrine that black is white.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* RET binding in vc-annotate and log-view [was: Re: Add a keybinding to vc-dir]
  2009-12-02  2:08   ` Miles Bader
@ 2009-12-02  3:04     ` Dan Nicolaescu
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Nicolaescu @ 2009-12-02  3:04 UTC (permalink / raw)
  To: Miles Bader; +Cc: Chong Yidong, emacs-devel

Miles Bader <miles@gnu.org> writes:

  > Dan Nicolaescu <dann@ics.uci.edu> writes:
  > >  Please don't add "d" to vc-dir. 
  > >  d can be used for other things in vc-dir in the future, and = is already
  > >  easy enough to type.
  > 
  > Yeah, ... "=" seems the usual emacs thingie for diffing, so it seems
  > good to emphasize that.

How about your older proposal to add a binding for RET in log-view and
vc-annotate ?  It would be nice to have that before the feature freeze...




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-12-02  3:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-01 19:32 Add a keybinding to vc-dir Chong Yidong
2009-12-01 19:39 ` Dan Nicolaescu
2009-12-02  2:08   ` Miles Bader
2009-12-02  3:04     ` RET binding in vc-annotate and log-view [was: Re: Add a keybinding to vc-dir] Dan Nicolaescu

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.