bug#5078: 23.1.50; vc broken

bug#5078: 23.1.50; vc broken

[Leo]

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug.  If you can, give
a recipe starting from `emacs -Q':

For files that are placed in a subdirectory (where there's no .git) of a
git repo, vc now thinks a file unchanged even if there are changes.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/Applications/Emacs.app/Contents/Resources/etc/DEBUG.


In GNU Emacs 23.1.50.1 (i386-apple-darwin9.8.0, NS apple-appkit-949.54)
 of 2009-11-27 on victoria.local
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default enable-multibyte-characters: t

bug#5078: 23.1.50; vc broken

[Dan Nicolaescu]

Leo <sdl.web@gmail.com> writes:

  > Please describe exactly what actions triggered the bug
  > and the precise symptoms of the bug.  If you can, give
  > a recipe starting from `emacs -Q':
  > 
  > For files that are placed in a subdirectory (where there's no .git) of a
  > git repo, vc now thinks a file unchanged even if there are changes.

Can you please send a detailed recipe starting from emacs -Q of how to
reproduce this?

bug#5078: 23.1.50; vc broken

[Leo]

On 2009-11-30 16:46 +0000, Dan Nicolaescu wrote:
> Leo <sdl.web@gmail.com> writes:
>
>   > Please describe exactly what actions triggered the bug
>   > and the precise symptoms of the bug.  If you can, give
>   > a recipe starting from `emacs -Q':
>   > 
>   > For files that are placed in a subdirectory (where there's no .git) of a
>   > git repo, vc now thinks a file unchanged even if there are changes.
>
> Can you please send a detailed recipe starting from emacs -Q of how to
> reproduce this?

I think I am seeing an odd bug.

There's a file in one of my projects that Emacs (with -Q) VC can't see
its changes. However, I can use magit to see its changes without any
problem. I tried to reproduce this problem with a newly created git repo
but with no luck.

Could you let me know how I can debug this further? Thanks.

Leo

bug#5078: 23.1.50; vc broken

[Dan Nicolaescu]

Leo <sdl.web@gmail.com> writes:

  > On 2009-11-30 16:46 +0000, Dan Nicolaescu wrote:
  > > Leo <sdl.web@gmail.com> writes:
  > >
  > >   > Please describe exactly what actions triggered the bug
  > >   > and the precise symptoms of the bug.  If you can, give
  > >   > a recipe starting from `emacs -Q':
  > >   > 
  > >   > For files that are placed in a subdirectory (where there's no .git) of a
  > >   > git repo, vc now thinks a file unchanged even if there are changes.
  > >
  > > Can you please send a detailed recipe starting from emacs -Q of how to
  > > reproduce this?
  > 
  > I think I am seeing an odd bug.
  > 
  > There's a file in one of my projects that Emacs (with -Q) VC can't see
  > its changes. However, I can use magit to see its changes without any
  > problem. I tried to reproduce this problem with a newly created git repo
  > but with no luck.
  > 
  > Could you let me know how I can debug this further? Thanks.


With the file that you have problems with in the current buffer, try to debug:

M-: (vc-git-state (buffer-file-name)) RET

bug#5078: 23.1.50; vc broken

[Leo]

On 2009-11-30 19:59 +0000, Dan Nicolaescu wrote:
[...]
>   > I think I am seeing an odd bug.
>   > 
>   > There's a file in one of my projects that Emacs (with -Q) VC can't see
>   > its changes. However, I can use magit to see its changes without any
>   > problem. I tried to reproduce this problem with a newly created git repo
>   > but with no luck.
>   > 
>   > Could you let me know how I can debug this further? Thanks.
>
>
> With the file that you have problems with in the current buffer, try to debug:
>
> M-: (vc-git-state (buffer-file-name)) RET

That returns: up-to-date

while the difference is:

@@ -27,7 +27,7 @@
-\DeclareSymbolFont{numbers}{OT1}{cmr}{m}{n}
+     dkdk\DeclareSymbolFont{numbers}{OT1}{cmr}{m}{n}

Leo

bug#5078: 23.1.50; vc broken

[Dan Nicolaescu]

Leo <sdl.web@gmail.com> writes:

  > On 2009-11-30 19:59 +0000, Dan Nicolaescu wrote:
  > [...]
  > >   > I think I am seeing an odd bug.
  > >   > 
  > >   > There's a file in one of my projects that Emacs (with -Q) VC can't see
  > >   > its changes. However, I can use magit to see its changes without any
  > >   > problem. I tried to reproduce this problem with a newly created git repo
  > >   > but with no luck.
  > >   > 
  > >   > Could you let me know how I can debug this further? Thanks.
  > >
  > >
  > > With the file that you have problems with in the current buffer, try to debug:
  > >
  > > M-: (vc-git-state (buffer-file-name)) RET
  > 
  > That returns: up-to-date

Please try to debug that function and figure out why it returns 'up-to-date. 

  > while the difference is:
  > 
  > @@ -27,7 +27,7 @@
  > -\DeclareSymbolFont{numbers}{OT1}{cmr}{m}{n}
  > +     dkdk\DeclareSymbolFont{numbers}{OT1}{cmr}{m}{n}
  > 
  > Leo

bug#5078: 23.1.50; vc broken

[Leo]

On 2009-12-01 00:07 +0000, Dan Nicolaescu wrote:
> Please try to debug that function and figure out why it returns 'up-to-date. 


I set vc-git-state with edebug and then made some changes to the file.
The following are some return values inside vc-git-state. Does it give a
clue?

1. (vc-git--call nil "add" "--refresh" "--" (file-relative-name file))

returns result: 128 (#o200, #x80, ?\200)

2. (vc-git--run-command-string file "diff-index" "-z" "HEAD" "--")

returns empty string ""

If I clone the repo, the problem goes away.

Best,

Leo

bug#5078: 23.1.50; vc broken

[Dan Nicolaescu]

Leo <sdl.web@gmail.com> writes:

  > On 2009-12-01 00:07 +0000, Dan Nicolaescu wrote:
  > > Please try to debug that function and figure out why it returns 'up-to-date. 
  > 
  > 
  > I set vc-git-state with edebug and then made some changes to the file.
  > The following are some return values inside vc-git-state. Does it give a
  > clue?
  > 
  > 1. (vc-git--call nil "add" "--refresh" "--" (file-relative-name file))
  > 
  > returns result: 128 (#o200, #x80, ?\200)
  > 
  > 2. (vc-git--run-command-string file "diff-index" "-z" "HEAD" "--")
  > 
  > returns empty string ""

It seems that git thinks there's no change, if you change that line to:

(vc-git--run-command-string file "diff-index" "-p" "-z" "HEAD" "--")

does it return the diff you've shown in a previous message?

  > If I clone the repo, the problem goes away.

Maybe something is corrupted in your tree, maybe comparing the 2 .git
directories could give some clues.

bug#5078: marked as done (23.1.50; vc broken)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 828 bytes --]

Your message dated Tue, 01 Dec 2009 14:56:50 +0000
with message-id <m0tywaagjx.fsf@cam.ac.uk>
and subject line Re: bug#5078: 23.1.50; vc broken
has caused the Emacs bug report #5078,
regarding 23.1.50; vc broken
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
5078: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=5078
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3205 bytes --]

From: Leo <sdl.web@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: 23.1.50; vc broken
Date: Mon, 30 Nov 2009 11:44:32 +0000
Message-ID: <m0638sdyov.fsf@cam.ac.uk>

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug.  If you can, give
a recipe starting from `emacs -Q':

For files that are placed in a subdirectory (where there's no .git) of a
git repo, vc now thinks a file unchanged even if there are changes.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/Applications/Emacs.app/Contents/Resources/etc/DEBUG.


In GNU Emacs 23.1.50.1 (i386-apple-darwin9.8.0, NS apple-appkit-949.54)
 of 2009-11-27 on victoria.local
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default enable-multibyte-characters: t


[-- Attachment #3: Type: message/rfc822, Size: 3056 bytes --]

From: Leo <sdl.web@gmail.com>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: 5078-done@emacsbugs.donarmstrong.com
Subject: Re: bug#5078: 23.1.50; vc broken
Date: Tue, 01 Dec 2009 14:56:50 +0000
Message-ID: <m0tywaagjx.fsf@cam.ac.uk>

On 2009-12-01 02:00 +0000, Dan Nicolaescu wrote:
>   > I set vc-git-state with edebug and then made some changes to the file.
>   > The following are some return values inside vc-git-state. Does it give a
>   > clue?
>   > 
>   > 1. (vc-git--call nil "add" "--refresh" "--" (file-relative-name file))
>   > 
>   > returns result: 128 (#o200, #x80, ?\200)
>   > 
>   > 2. (vc-git--run-command-string file "diff-index" "-z" "HEAD" "--")
>   > 
>   > returns empty string ""
>
> It seems that git thinks there's no change, if you change that line to:
>
> (vc-git--run-command-string file "diff-index" "-p" "-z" "HEAD" "--")
>
> does it return the diff you've shown in a previous message?

It returns the empty string "" as well.

>   > If I clone the repo, the problem goes away.
>
> Maybe something is corrupted in your tree, maybe comparing the 2 .git
> directories could give some clues.

I think it might be due to incompatibility between git 1.4.x and 1.5.x
as all new repos do not have this problem. This bug can be closed. Thank
you very much for your help along the way.

Best,

Leo