From: Mark Lillibridge <mark.lillibridge@hp.com>
To: bug-gnu-emacs@gnu.org
Subject: bug#5042: 23.1; linum-mode gives incorrect line numbers with narrowed buffers
Date: Wed, 25 Nov 2009 16:39:29 -0800 [thread overview]
Message-ID: <200911260039.nAQ0dTD1019384@mailhub-pa1.hpl.hp.com> (raw)
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.
Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:
Linum-mode does not work correctly with buffers that have been
narrowed. As a simple example, type ^h i. You will note that the first
line is assigned line number one. You can verify that this is wrong
either by using goto-line (watch what happens when you try to go to line
10) or widen, which reveals that the first line is actually line number
five.
The bug is the use by linum of line-number-at-pos,
linum.el:129:
(defun linum-update-window (win)
"Update line numbers for the portion visible in window WIN."
(goto-char (window-start win))
(let ((line (line-number-at-pos))
...
<help for line-number-at-pos>:
line-number-at-pos is a compiled Lisp function in `simple.el'.
(line-number-at-pos &optional pos)
Return (narrowed) buffer line number at position pos.
If pos is nil, use current buffer location.
Counting starts at (point-min), so the value refers
to the contents of the accessible portion of the buffer.
A simple fix is to change the line:
linum.el:132:
(let ((line (line-number-at-pos))
to:
(let ((line (save-restriction
(widen)
(line-number-at-pos)))
- Mark
next reply other threads:[~2009-11-26 0:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 0:39 Mark Lillibridge [this message]
2009-12-01 0:32 ` bug#5042: 23.1; linum-mode gives incorrect line numbers with narrowed buffers Juanma Barranquero
2009-12-10 5:34 ` Mark Lillibridge
2009-12-10 11:41 ` Juanma Barranquero
2009-12-21 6:59 ` Mark Lillibridge
2009-12-21 10:37 ` Juanma Barranquero
2009-12-21 15:50 ` Drew Adams
2009-12-23 20:49 ` Mark Lillibridge
2009-12-23 21:01 ` Drew Adams
2009-12-23 21:44 ` Mark Lillibridge
2009-12-24 3:49 ` Stefan Monnier
2009-12-29 7:02 ` Kevin Rodgers
2010-01-07 5:38 ` Mark Lillibridge
2010-01-07 23:30 ` Markus Triska
2010-01-10 1:32 ` Mark Lillibridge
2010-01-10 1:56 ` Juanma Barranquero
2010-01-16 22:08 ` Mark Lillibridge
2010-01-16 23:03 ` Juanma Barranquero
2010-01-23 23:28 ` Mark Lillibridge
2010-01-24 0:07 ` Drew Adams
2010-02-03 5:01 ` Mark Lillibridge
2010-01-24 9:21 ` Juanma Barranquero
2010-01-10 2:05 ` Lennart Borgman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911260039.nAQ0dTD1019384@mailhub-pa1.hpl.hp.com \
--to=mark.lillibridge@hp.com \
--cc=5042@emacsbugs.donarmstrong.com \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.