From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#4828: 23.1.50; c-newline-and-indent and indent-line-function Date: Sun, 22 Nov 2009 08:22:50 +0000 Message-ID: <20091122082250.GA1436@muc.de> References: Reply-To: Alan Mackenzie , 4828@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1258878464 2769 80.91.229.12 (22 Nov 2009 08:27:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Nov 2009 08:27:44 +0000 (UTC) Cc: 4828@emacsbugs.donarmstrong.com To: Lennart Borgman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 22 09:27:37 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NC7nE-0002fC-Gf for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Nov 2009 09:27:36 +0100 Original-Received: from localhost ([127.0.0.1]:51002 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NC7nD-0004Uh-Nm for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Nov 2009 03:27:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NC7n7-0004UL-QQ for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2009 03:27:29 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NC7n2-0004Tt-OA for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2009 03:27:29 -0500 Original-Received: from [199.232.76.173] (port=33857 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NC7n2-0004Tq-Is for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2009 03:27:24 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:41185) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NC7n2-000408-5G for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2009 03:27:24 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAM8RLgm030776; Sun, 22 Nov 2009 00:27:21 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAM8P5MR030499; Sun, 22 Nov 2009 00:25:05 -0800 Resent-Date: Sun, 22 Nov 2009 00:25:05 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Alan Mackenzie Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sun, 22 Nov 2009 08:25:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4828 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4828-submit@emacsbugs.donarmstrong.com id=B4828.125887786730050 (code B ref 4828); Sun, 22 Nov 2009 08:25:05 +0000 Original-Received: (at 4828) by emacsbugs.donarmstrong.com; 22 Nov 2009 08:17:47 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.muc.de (qmailr@colin.muc.de [193.149.48.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAM8Hjgk030047 for <4828@emacsbugs.donarmstrong.com>; Sun, 22 Nov 2009 00:17:46 -0800 Original-Received: (qmail 21910 invoked by uid 3782); 22 Nov 2009 08:17:42 -0000 Original-Received: from acm.muc.de (pD9E528AC.dip.t-dialin.net [217.229.40.172]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Sun, 22 Nov 2009 09:17:41 +0100 Original-Received: (qmail 2996 invoked by uid 1000); 22 Nov 2009 08:22:50 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) X-Primary-Address: acm@muc.de X-MIME-Autoconverted: from 8bit to quoted-printable by rzlab.ucr.edu id nAM8RLgm030776 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sun, 22 Nov 2009 03:27:28 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32814 Archived-At: Hi, Lennart! On Sat, Nov 21, 2009 at 03:09:08PM +0100, Lennart Borgman wrote: > On Fri, Oct 30, 2009 at 2:08 AM, Stefan Monnier > wrote: > >> c-newline-and-indent calls indent-according-to-mode to get indentati= on > > [...] > >> I do not know how to solve this problem, but perhaps is it possible = that > >> c-newline-and-indent instead calls indent-line-function? > > Why would that help? =A0indent-according-to-mode doesn't do much more= than > > call indent-line-function. > Eh, sorry. > Looking at the code in c-electric-semi&comma I think it is better to > change the call to (c-indent-line) currently on line 938 in cc-cmds.el > to (funcall indent-line-function). That will fix the problem I think. > (if c-syntactic-indentation > ;;(c-indent-line) > (funcall indent-line-function) > ) > Would that be the right fix Alan? I reckon so; it looks like a proper fix, not a workaround. But if you could comment it something like: (funcall indent-line-function) ; Call indirectly for mum= amo , the chance of it being "cleaned up" at a later date would be considerably diminished.=09 If you want to commit this change, it's fine as far as I'm concerned. --=20 Alan Mackenzie (Nuremberg, Germany).