From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#4972: 23.1.50; Can't view revision log from Hg annotate buffer Date: Thu, 19 Nov 2009 10:43:57 -0800 (PST) Message-ID: <200911191843.nAJIhv1G022475@godzilla.ics.uci.edu> References: <84aayilgmw.fsf@linux-b2a3.site> Reply-To: Dan Nicolaescu , 4972@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1258657700 4277 80.91.229.12 (19 Nov 2009 19:08:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Nov 2009 19:08:20 +0000 (UTC) Cc: 4972@emacsbugs.donarmstrong.com To: Magnus Henoch Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 19 20:08:10 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NBCMS-0004Cn-Fz for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Nov 2009 20:08:08 +0100 Original-Received: from localhost ([127.0.0.1]:35241 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBCMR-00039x-QB for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Nov 2009 14:08:07 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBCLo-00030F-NJ for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2009 14:07:28 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBCLj-0002z5-W2 for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2009 14:07:28 -0500 Original-Received: from [199.232.76.173] (port=39708 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBCLj-0002z2-Pr for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2009 14:07:23 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:47607) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NBCLj-0004yH-6A for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2009 14:07:23 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAJJ7Ku7031771; Thu, 19 Nov 2009 11:07:21 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAJIo4mJ029569; Thu, 19 Nov 2009 10:50:04 -0800 Resent-Date: Thu, 19 Nov 2009 10:50:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 19 Nov 2009 18:50:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4972 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4972-submit@emacsbugs.donarmstrong.com id=B4972.125865624929081 (code B ref 4972); Thu, 19 Nov 2009 18:50:04 +0000 Original-Received: (at 4972) by emacsbugs.donarmstrong.com; 19 Nov 2009 18:44:09 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from paul-mcgann-v0.ics.uci.edu (paul-mcgann-v0.ics.uci.edu [128.195.1.147]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAJIi8Fh029078 for <4972@emacsbugs.donarmstrong.com>; Thu, 19 Nov 2009 10:44:09 -0800 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nAJIhv6p004777 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 19 Nov 2009 10:43:57 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nAJIhv1G022475; Thu, 19 Nov 2009 10:43:57 -0800 (PST) In-Reply-To: <84aayilgmw.fsf@linux-b2a3.site> (Magnus Henoch's message of "Thu, 19 Nov 2009 14:43:19 +0000") Original-Lines: 36 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nAJIhv6p004777 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 19 Nov 2009 14:07:28 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32723 Archived-At: Magnus Henoch writes: > Please write in English if possible, because the Emacs maintainers > usually do not have translators to read other languages for them. >=20 > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing= list. >=20 > Please describe exactly what actions triggered the bug > and the precise symptoms of the bug. If you can, give > a recipe starting from `emacs -Q': >=20 > When I open a file managed by Mercurial, hit C-x v g to annotate it, and > hit `l' to view the log message of the revision of the current line, I > get this: >=20 > Debugger entered--Lisp error: (wrong-number-of-arguments #[(backend fil= es working-revision limit) "*byte code removed*" [pl-return vc-short-log di= r-present files file --cl-dolist-temp-- nil file-directory-p t directory vc= -call-backend print-log "*vc-change-log*" pop-to-buffer vc-exec-after let (= inhibit-read-only t) quote ((quote log-view-mode)) set (make-local-variable= (quote log-view-vc-backend)) (make-local-variable (quote log-view-vc-files= et)) when and ((not (eq (quote limit-unsupported) pl-return))) (goto-char (= point-max)) widget-create (quote push-button) :notify lambda (&rest ignore)= vc-print-log-internal * 2 (:help-echo "Show the log again, and double the = number of log entries shown" "Show 2X entries") (widget-insert " ") (quo= te push-button) (&rest ignore) (nil) (:help-echo "Show the log again, showi= ng all entries" "Show unlimited entries") ((widget-setup)) (shrink-window-i= f-larger-than-buffer) (quote show-log-entry) ((setq vc-sentinel-movepoint (= point)) (set-buffer-modified-p nil)) vc-log-short-style backend limit worki= ng-revision] 21] 3) > vc-print-log-internal(Hg ("/home/magnus/foo.erl") "23") > (if (not rev-at-line) (message "Cannot extract revision number from t= he current line") (vc-print-log-internal vc-annotate-backend (list ...) (ca= r rev-at-line))) > (let ((rev-at-line ...)) (if (not rev-at-line) (message "Cannot extra= ct revision number from the current line") (vc-print-log-internal vc-annota= te-backend ... ...))) > (if (not (equal major-mode ...)) (message "Cannot be invoked outside = of a vc annotate buffer") (let (...) (if ... ... ...))) > vc-annotate-show-log-revision-at-line() > call-interactively(vc-annotate-show-log-revision-at-line nil nil) This should fix it. --- vc-annotate.el.~1.10.~ Thu Nov 19 0= 7:37:30 2009 +++ vc-annotate.el Thu Nov 19 1= 0:42:54 2009 @@ -487,7 +487,7 @@ Return a cons (REV . FILENAME)." (if (not rev-at-line) (message "Cannot extract revision number from the current line") (vc-print-log-internal - vc-annotate-backend (list (cdr rev-at-line)) (car rev-at-line))))= )) + vc-annotate-backend (list (cdr rev-at-line)) (car rev-at-line) n= il))))) =20 (defun vc-annotate-show-diff-revision-at-line-internal (filediff) (if (not (equal major-mode 'vc-annotate-mode))