From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: limit the number of log entries displayed by C-x v l Date: Sun, 15 Nov 2009 12:55:18 -0800 (PST) Message-ID: <200911152055.nAFKtI8E006868@godzilla.ics.uci.edu> References: <200911122319.nACNJvUn006154@godzilla.ics.uci.edu> <200911130221.nAD2Lu4q007527@godzilla.ics.uci.edu> <200911130502.nAD52OVv008802@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1258318634 7604 80.91.229.12 (15 Nov 2009 20:57:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Nov 2009 20:57:14 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 15 21:57:07 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N9m9i-0001Ef-SV for ged-emacs-devel@m.gmane.org; Sun, 15 Nov 2009 21:57:07 +0100 Original-Received: from localhost ([127.0.0.1]:43219 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N9m9i-0005DW-Fe for ged-emacs-devel@m.gmane.org; Sun, 15 Nov 2009 15:57:06 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N9m9e-0005Cq-0A for emacs-devel@gnu.org; Sun, 15 Nov 2009 15:57:02 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N9m9Z-0005AG-GE for emacs-devel@gnu.org; Sun, 15 Nov 2009 15:57:01 -0500 Original-Received: from [199.232.76.173] (port=37729 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N9m9Y-0005A1-Va for emacs-devel@gnu.org; Sun, 15 Nov 2009 15:56:57 -0500 Original-Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]:53282) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N9m9Y-0002Lw-9e for emacs-devel@gnu.org; Sun, 15 Nov 2009 15:56:56 -0500 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nAFKtJjN016238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 15 Nov 2009 12:55:19 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nAFKtI8E006868; Sun, 15 Nov 2009 12:55:18 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Fri, 13 Nov 2009 09:10:55 -0500") Original-Lines: 42 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nAFKtJjN016238 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:117012 Archived-At: Stefan Monnier writes: > >> > With the proposed backend change that just needs > >> > vc-annotate-show-log-revision-at-line to pass a 1 as the last argument > >> > to vc-print-log-internal. > >> Assuming we retarget the `working-revision' argument to specify the > >> "starting" revision, I guess. Yes, that could work. > > Actually, after looking a bit more we'd need more changes, the > > `working-revision' is not passed to the `print-log' VC method, so a bit > > more work would be needed for that :-( > > But this does not affect my original proposal, which is still needed. > > Yes, I'm not opposing it, I checked a patch that adds the LIMIT argument. LIMIT defaults to the value of new variable vc-log-show-limit (not a very good name). vc-log-show-limit is set to 0 (meaning no limit), so the default behavior has not changed. Please feel free to change the default value. The limit can be set interactively when using a prefix argument. I changed all the backends that do not support LIMIT to ignore it. And I added support for it for all the ones that do, except for Git. Git has enough fans on this list, so surely someone else will do it. I'll work on adding button(s) to request more entries. > I'm just trying to get a better general > picture. Some of the problems we may encounter is that some backends > don't support the `limit' argument. Hopefully all those backends can > easily turn a "print-log FILE REV LIMIT=1" request into "print-log FILE > REV1 REV2" instead, tho. Not sure what to do for other values of LIMIT, > but maybe that's doable as well. It seems that for this we need to add another argument to the `print-log' VC method: START-REVISION. Do we want to also add END-REVISION? Given that vc-annotate would only use START-REVISION in conjunction with LIMIT==1, we can document that the backends should only support that combination, at least for the time being.