From: Andrew Lawson <adl@absentis.com>
To: org-mode Mailinglist <emacs-orgmode@gnu.org>
Subject: Bug in org-icalendar.el
Date: Wed, 4 Nov 2009 12:04:57 +0100 [thread overview]
Message-ID: <20091104110457.GA18193@absentis.com> (raw)
Hi all
Just noticed an issue with a recent commit d51a8307 which defines
org-icalendar-verify-function as nil but tests it using 'boundp. I'm
using revision a7543733... The fix is:
@@ -280,7 +280,7 @@ When COMBINE is non nil, add the category to each
line."
(while (re-search-forward re1 nil t)
(catch :skip
(org-agenda-skip)
- (when (boundp 'org-icalendar-verify-function)
+ (when org-icalendar-verify-function
(unless (funcall org-icalendar-verify-function)
(outline-next-heading)
(backward-char 1)
@@ -403,7 +403,7 @@ END:VEVENT\n"
(while (re-search-forward org-todo-line-regexp nil t)
(catch :skip
(org-agenda-skip)
- (when (boundp 'org-icalendar-verify-function)
+ (when org-icalendar-verify-function
(unless (save-match-data
(funcall org-icalendar-verify-function))
(outline-next-heading)
After that I have further problems with a nil org-todo-line regexp in:
re-search-forward(nil nil t)
org-print-icalendar-entries(t)
but I'm off to a meeting. I'll have a look later
Andrew
--
____ Andrew Lawson ____
adl at absentis dot com
A notebook, a fountain pen, a good book for inspiration, a spot of tea
and an expansive view, could one ask for anything more?
next reply other threads:[~2009-11-04 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 11:04 Andrew Lawson [this message]
2009-11-05 7:08 ` Bug in org-icalendar.el Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091104110457.GA18193@absentis.com \
--to=adl@absentis.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.