From: Bernhard Herzog <bernhard.herzog@intevation.de>
To: emacs-devel@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: Patch to make vc-hg.el work with remote files
Date: Wed, 28 Oct 2009 19:05:11 +0100 [thread overview]
Message-ID: <200910281905.12147.bernhard.herzog@intevation.de> (raw)
In-Reply-To: <jwvd448w9t7.fsf-monnier+emacs@gnu.org>
On 28.10.2009, Stefan Monnier wrote:
> > Indeed. Here's a new patch.
>
> Thanks, installed.
Great!
> But I wonder about the last hunk of your patch:
> > @@ -286,7 +288,6 @@
> > (setq oldvers working))
> > (apply #'vc-hg-command (or buffer "*vc-diff*") nil
> > (mapcar (lambda (file) (file-relative-name file cwd)) files)
> > - "--cwd" cwd
> > "diff"
> > (append
> > (vc-switches 'hg 'diff)
>
> What is the reason for it?
The reason I changed vc-hg-diff at all was that it doesn't work correctly with
tramp. cwd is the name of the directory containing the file to diff and if
file is on a remote system it's a tramp filename which mercurial doesn't
understand, of course.
I've looked a bit closer at it now and AFAICT vc-hg-diff can be made even
simpler and probably more correct by passing files unmodified to
vc-hg-command. I don't have the time right now to test and produce a better
patch, though. I hope to get around to that tomorrow.
Does anybody know why in vc-hg.el vc-hg-command is sometimes called directly
and sometimes via apply?
Regards
Bernhard
next prev parent reply other threads:[~2009-10-28 18:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-25 17:56 Patch to make vc-hg.el work with remote files Bernhard Herzog
2009-10-26 2:00 ` Stefan Monnier
2009-10-27 12:01 ` Bernhard Herzog
2009-10-28 2:07 ` Stefan Monnier
2009-10-28 18:05 ` Bernhard Herzog [this message]
2009-11-02 21:34 ` Bernhard Herzog
2009-11-02 21:58 ` Dan Nicolaescu
2009-11-02 23:52 ` Bernhard Herzog
2009-11-02 22:00 ` Sam Steingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910281905.12147.bernhard.herzog@intevation.de \
--to=bernhard.herzog@intevation.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.