From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#4677: allow VC operations from dired Date: Fri, 23 Oct 2009 11:21:07 -0700 (PDT) Message-ID: <200910231821.n9NIL7Qk000637@godzilla.ics.uci.edu> References: <200910082019.n98KJxFW020300@godzilla.ics.uci.edu> <87k4z1o58n.fsf@mail.jurta.org> <200910120246.n9C2kOsV025230@godzilla.ics.uci.edu> <87vdiks99u.fsf@mail.jurta.org> Reply-To: Dan Nicolaescu , 4677@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1256322480 29406 80.91.229.12 (23 Oct 2009 18:28:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Oct 2009 18:28:00 +0000 (UTC) Cc: 4677@emacsbugs.donarmstrong.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 23 20:27:47 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N1OrX-0002kp-48 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Oct 2009 20:27:43 +0200 Original-Received: from localhost ([127.0.0.1]:40597 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N1OrW-0007Hz-Gr for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Oct 2009 14:27:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N1OrE-0007Bp-Ga for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2009 14:27:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N1Or6-00077I-No for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2009 14:27:21 -0400 Original-Received: from [199.232.76.173] (port=45375 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N1Or6-00076q-IT for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2009 14:27:16 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:44545) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N1Or5-0003eh-JO for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2009 14:27:16 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9NIRDmT007510; Fri, 23 Oct 2009 11:27:13 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n9NIPCe9007226; Fri, 23 Oct 2009 11:25:12 -0700 Resent-Date: Fri, 23 Oct 2009 11:25:12 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 23 Oct 2009 18:25:12 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4677 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4677-submit@emacsbugs.donarmstrong.com id=B4677.12563220776825 (code B ref 4677); Fri, 23 Oct 2009 18:25:12 +0000 Original-Received: (at 4677) by emacsbugs.donarmstrong.com; 23 Oct 2009 18:21:17 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from paul-mcgann-v0.ics.uci.edu (paul-mcgann-v0.ics.uci.edu [128.195.1.147]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9NILGa4006821 for <4677@emacsbugs.donarmstrong.com>; Fri, 23 Oct 2009 11:21:17 -0700 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id n9NIL7eL027134; Fri, 23 Oct 2009 11:21:07 -0700 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n9NIL7Qk000637; Fri, 23 Oct 2009 11:21:07 -0700 (PDT) In-Reply-To: <87vdiks99u.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 12 Oct 2009 23:27:09 +0300") Original-Lines: 21 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: n9NIL7eL027134 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Fri, 23 Oct 2009 14:27:21 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32195 Archived-At: Juri Linkov writes: > > > > This patch allows VC operations to be run from dired. > > > > State changing VC operations are not supported. > > > > (only the various variations of log and diff) > > > > > > Thanks, it works right except in one case: when called outside of > > > a repository controlled directory, it traverses all subdirectories > > > trying to find a repository (I think traversing subdirectories > > > makes no sense in this case) and later fails with: > > > > > > Wrong type argument: stringp, nil > > > > Thanks. Here's an updated patch. > > Hmm, now it fails with "Directory not under VC" in all directories > even under version control since (vc-backend default-directory) > always returns nil. The version that uses vc-responsible-backend should work correctly now (i.e. it will throw an error) when used in a non VC controlled directory.