From: Dan Nicolaescu <dann@ics.uci.edu>
To: Adrian Robert <adrian.b.robert@gmail.com>
Cc: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: 64-bit compilation and printfs
Date: Wed, 14 Oct 2009 09:40:06 -0700 (PDT) [thread overview]
Message-ID: <200910141640.n9EGe6o7024021@godzilla.ics.uci.edu> (raw)
In-Reply-To: <4CE21A3C-B51B-45ED-B51B-86072D403E25@gmail.com> (Adrian Robert's message of "Sun, 11 Oct 2009 20:46:27 -0400")
Adrian Robert <adrian.b.robert@gmail.com> writes:
> In the course of getting the NS port compiling in 64-bit mode, some
> other developers and myself discovered some format - arg mismatches in
> printfs. XINT and XUINT return EMACS_INT which can be a long under
> LP64. I'd like to replace places that use %d in the code with %ld,
> and cast the argument to (long) to avoid issues in 32-bit mode. This
> has been checked in for the NS port; the patch attached here does this
> in common code. Does anyone think this should be done differently?
It looks like this the 64-bit mode uses the 32-bit configuration file.
From configure.in:
## Apple Darwin / Mac OS X
*-apple-darwin* )
case "${canonical}" in
i[3456]86-* ) machine=intel386 ;;
powerpc-* ) machine=macppc ;;
* ) unported=yes ;;
esac
there should be an:
x86_64-* ) machine=amdx86-64 ;;
in that "case".
that will allow to remove this from emacs/src/s/intel386.h:
#if defined (DARWIN_OS)
#ifdef _LP64
/* For Intel Mac, with CC='gcc -arch x86_64'. */
#define NO_ARG_ARRAY
#endif
#endif
there shouldn't be any _LP64 checks in that file.
next prev parent reply other threads:[~2009-10-14 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 0:46 64-bit compilation and printfs Adrian Robert
2009-10-12 4:03 ` Eli Zaretskii
2009-10-12 14:44 ` Adrian Robert
2009-10-12 8:48 ` Andreas Schwab
2009-10-13 19:34 ` Stefan Monnier
2009-10-14 16:40 ` Dan Nicolaescu [this message]
2009-10-14 17:50 ` Adrian Robert
2009-10-14 18:17 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910141640.n9EGe6o7024021@godzilla.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=adrian.b.robert@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.