From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#4515: 23.1.50; Reverting changes on versioned file does not revert vc modeline status Date: Thu, 24 Sep 2009 10:20:51 -0700 (PDT) Message-ID: <200909241720.n8OHKpiG010343@godzilla.ics.uci.edu> References: <87ws3rlnny.fsf@telefonica.net> <200909230553.n8N5rEsT023798@godzilla.ics.uci.edu> <87eipykve3.fsf@telefonica.net> <200909231836.n8NIa6Lv029481@godzilla.ics.uci.edu> <874oqtlaq0.fsf@telefonica.net> <200909240424.n8O4OjLB004582@godzilla.ics.uci.edu> <87skeckghp.fsf@telefonica.net> Reply-To: Dan Nicolaescu , 4515@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1253814444 14800 80.91.229.12 (24 Sep 2009 17:47:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Sep 2009 17:47:24 +0000 (UTC) Cc: 4515@emacsbugs.donarmstrong.com To: =?UTF-8?Q?=C3=93scar?= Fuentes Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 24 19:47:17 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MqsPU-00010W-Ox for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Sep 2009 19:47:17 +0200 Original-Received: from localhost ([127.0.0.1]:38288 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqsPT-0001Ja-S2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Sep 2009 13:47:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqsPP-0001JH-F1 for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 13:47:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqsPL-0001Il-Tn for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 13:47:11 -0400 Original-Received: from [199.232.76.173] (port=44896 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqsPL-0001IY-KF for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 13:47:07 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:58338) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MqsPK-0003zb-VM for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 13:47:07 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OHl4QR028295; Thu, 24 Sep 2009 10:47:04 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8OHU4Sc025951; Thu, 24 Sep 2009 10:30:04 -0700 Resent-Date: Thu, 24 Sep 2009 10:30:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 24 Sep 2009 17:30:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4515 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4515-submit@emacsbugs.donarmstrong.com id=B4515.125381286924965 (code B ref 4515); Thu, 24 Sep 2009 17:30:03 +0000 Original-Received: (at 4515) by emacsbugs.donarmstrong.com; 24 Sep 2009 17:21:09 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OHL738024962 for <4515@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 10:21:08 -0700 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8OHKpTw011757; Thu, 24 Sep 2009 10:20:52 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8OHKpiG010343; Thu, 24 Sep 2009 10:20:51 -0700 (PDT) In-Reply-To: <87skeckghp.fsf@telefonica.net> =?UTF-8?Q?("=C3=93scar?= Fuentes"'s message of "Thu, 24 Sep 2009 08:24:02 +0200") Original-Lines: 31 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8OHKpTw011757 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 24 Sep 2009 13:47:11 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31463 Archived-At: =C3=93scar Fuentes writes: > Dan Nicolaescu writes: >=20 > > Stefan Monnier writes: > > > > > > Automatically checking the VC state after each save is actually > > > > performed if there is a vc-dired buffer for the working copy wh= ere the > > > > file resides. That check updates the vc-dired with the correct = state of > > > > the saved file. > > >=20 > > > Indeed. That requires the status info to be obtainable cheaply. > > > > There's a major difference: vc-dir is asynchronous, whereas updating = the > > same info when saving a file is synchronous, so it will be on the > > critical path. >=20 > Are you saying that vc-dir updates the file status asynchronously after > a file is saved? vc-dir-recompute-file-state does Hmm, I implemented that probably 2 years ago ago, but it does not look like I checked it in... and I can't seem to find that patch anymore. :-( > (state (vc-call-backend vc-dir-backend 'state fname)) > (extra (vc-call-backend vc-dir-backend > 'status-fileinfo-extra fname))) This function should instead be using `vc-dir-refresh-files' to work asynchronously. Given that nobody noticed this until now, maybe it's not too bad.