From: Dan Nicolaescu <dann@ics.uci.edu>
To: "Óscar Fuentes" <ofv@wanadoo.es>
Cc: 4515@emacsbugs.donarmstrong.com
Subject: bug#4515: 23.1.50; Reverting changes on versioned file does not revert vc modeline status
Date: Wed, 23 Sep 2009 14:21:37 -0700 (PDT) [thread overview]
Message-ID: <200909232121.n8NLLb89001068@godzilla.ics.uci.edu> (raw)
In-Reply-To: <874oqtlaq0.fsf@telefonica.net> ("Óscar Fuentes"'s message of "Wed, 23 Sep 2009 21:31:03 +0200")
Óscar Fuentes <ofv@wanadoo.es> writes:
> Dan Nicolaescu <dann@ics.uci.edu> writes:
>
> > Óscar Fuentes <ofv@wanadoo.es> writes:
> >
> > > Dan Nicolaescu <dann@ics.uci.edu> writes:
> > >
> > > > ofv@wanadoo.es. "(Óscar" Fuentes) writes:
> > > >
> > > > > Please write in English if possible, because the Emacs maintainers
> > > > > usually do not have translators to read other languages for them.
> > > > >
> > > > > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.
> > > > >
> > > > > Please describe exactly what actions triggered the bug
> > > > > and the precise symptoms of the bug:
> > > > >
> > > > > When a modified versioned file is edited in such a way that the
> > > > > modifications undoes previous changes to the file, after saving it the
> > > > > VC-dired buffer for the working copy is automatically updated showing
> > > > > that the status of the file is "up to date", but the VC modeline for the
> > > > > buffer that visits the file does not change and keeps indicating that
> > > > > the file state is "locally modified".
> > > >
> > > > Can you please describe step by step the actions necessary to reproduce
> > > > this starting from emacs -Q?
> > >
> > > emacs -Q
> > >
> > > C-x C-f some-versioned-unmodified-file
> > > do some edition
> > > C-x C-s (the VC status modeline indicator changes from `-' to `:')
> > > undo previous edition
> > > C-x C-s
> > >
> > > Now you just turned the file to its original state and is unmodified as
> > > far as the version control system is concerned, but the VC modeline
> > > keeps showing `:' (for example Bzr:836) indicating that the file is
> > > edited. After saving a versioned file, VC should check if the VC backend
> > > flags the file as edited and update the modeline accordingly.
> >
> > You can do M-x revert-buffer or C-x v u and that would reset the VC
> > state accordingly.
>
> Yes, I know.
>
> > Checking for this condition after each save is prohibitively expensive,
> > and it's an extremely rare event, so it's not worth optimizing for.
>
> Automatically checking the VC state after each save is actually
> performed if there is a vc-dired buffer for the working copy where the
> file resides. That check updates the vc-dired with the correct state of
> the saved file.
>
> Part of my job is experimenting tweaks and micro-improvements on
> existing code bases. After every session I end with lots of buffers
> showing the "edited" vc modeline indicator when in fact only one or two
> are effectively edited. This renders useless the vc state indicator and
> turns its meaning into "When `:' is shown, this file was edited, but it
> may be up-to-date now".
>
> > So this is neither a bug, not something worth improving.
>
> Well, the vc status on the modeline is showing the wrong state.
> Would you accept a patch that implements an option for checking after
> every save and updating the vc state on the modeline accordingly?
Although I've done a lot of work on VC, I am not an official maintainer
of VC, so I am in no position to do that. But I don't think such a
change is a good idea.
next prev parent reply other threads:[~2009-09-23 21:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 2:26 bug#4515: 23.1.50; Reverting changes on versioned file does not revert vc modeline status =C3=93scar?= Fuentes
2009-09-23 5:53 ` Dan Nicolaescu
2009-09-23 6:49 ` Óscar Fuentes
2009-09-23 18:36 ` Dan Nicolaescu
2009-09-23 19:31 ` Óscar Fuentes
2009-09-23 21:21 ` Dan Nicolaescu [this message]
2009-09-24 2:08 ` Kevin Rodgers
2009-09-24 2:25 ` Stefan Monnier
2009-09-24 4:24 ` Dan Nicolaescu
2009-09-24 6:24 ` Óscar Fuentes
2009-09-24 17:20 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909232121.n8NLLb89001068@godzilla.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=4515@emacsbugs.donarmstrong.com \
--cc=ofv@wanadoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.