all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Ivan Kanis <expire-by-2009-09-28@kanis.fr>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] term.el make bold face customizable
Date: Wed, 23 Sep 2009 09:41:46 -0700 (PDT)	[thread overview]
Message-ID: <200909231641.n8NGfksd028683@godzilla.ics.uci.edu> (raw)
In-Reply-To: <86ocp1hkd1.fsf@kanis.fr> (Ivan Kanis's message of "Wed, 23 Sep 2009 15:16:26 +0200")

Ivan Kanis <expire-by-2009-09-28@kanis.fr> writes:

  > Hi Dan,
  > 
  > Could you apply the following trivial patch?

I am against this kind of stuff.  Next we will have to add a way
customize something so that to not display the blue color for example?

You can modify the terminfo/termcap entry locally to not say that bold
is supported, then well behaved applications will not display bold.

You might want to try to convince Stefan to apply it.


  > Kind regards,
  > -- 
  > Ivan
  > Kanis http://kanis.fr
  > 
  > If you want others to be happy, practice compassion.
  > If you want to be happy, practice compassion.
  >     -- Dalai Lama 
  > 
  > --- tmp/term.el	2009-09-23 15:04:37.000000000 +0200
  > +++ hg/lisp/misc/term.el	2009-09-23 15:10:06.000000000 +0200
  > @@ -482,6 +482,9 @@
  >    :type '(choice (const nil) file)
  >    :group 'term)
  >  
  > +(defvar term-bold-attribute '(:weight bold)
  > +  "Set to '(:weight normal) to disable bold")
  > +
  >  (defvar term-prompt-regexp "^"
  >    "Regexp to recognize prompts in the inferior process.
  >  Defaults to \"^\", the null string at BOL.
  > @@ -3228,8 +3231,8 @@
  >  			    term-default-bg-color
  >  			  (elt ansi-term-color-vector term-ansi-current-bg-color))))
  >  	    (when term-ansi-current-bold
  > -	      (setq term-current-face
  > -		    (append '(:weight bold) term-current-face)))
  > +	      (setq term-current-face 
  > +		    (append term-bold-attribute term-current-face)))
  >  	    (when term-ansi-current-underline
  >  	      (setq term-current-face
  >  		    (append '(:underline t) term-current-face))))
  > @@ -3257,7 +3260,7 @@
  >  			(elt ansi-term-color-vector term-ansi-current-bg-color))))
  >  	  (when term-ansi-current-bold
  >  	    (setq term-current-face
  > -		  (append '(:weight bold) term-current-face)))
  > +		  (append term-bold-attribute term-current-face)))
  >  	  (when term-ansi-current-underline
  >  	    (setq term-current-face
  >  		  (append '(:underline t) term-current-face))))))




  reply	other threads:[~2009-09-23 16:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-23 13:16 [PATCH] term.el make bold face customizable Ivan Kanis
2009-09-23 16:41 ` Dan Nicolaescu [this message]
2009-09-23 20:52 ` Stefan Monnier
2009-09-24  1:16 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909231641.n8NGfksd028683@godzilla.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=expire-by-2009-09-28@kanis.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.