From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#4222: calls to char_table_ref slow down 23.1 (vs 22.3) Date: Fri, 18 Sep 2009 21:43:11 -0700 (PDT) Message-ID: <200909190443.n8J4hBNM011012@godzilla.ics.uci.edu> References: <87skejomoe.fsf@stupidchicken.com> Reply-To: Dan Nicolaescu , 4222@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253336877 7038 80.91.229.12 (19 Sep 2009 05:07:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Sep 2009 05:07:57 +0000 (UTC) Cc: 4222@emacsbugs.donarmstrong.com To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 19 07:07:50 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MosAo-0004vk-2v for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Sep 2009 07:07:50 +0200 Original-Received: from localhost ([127.0.0.1]:58566 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MosAn-0001YG-Kf for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Sep 2009 01:07:49 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MosAA-0001KP-IX for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2009 01:07:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MosA5-0001Gm-AI for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2009 01:07:09 -0400 Original-Received: from [199.232.76.173] (port=60830 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MosA5-0001GU-3m for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2009 01:07:05 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37000) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MosA4-0002Fc-IS for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2009 01:07:04 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8J572vl016348; Fri, 18 Sep 2009 22:07:02 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8J4o7gI013323; Fri, 18 Sep 2009 21:50:07 -0700 Resent-Date: Fri, 18 Sep 2009 21:50:07 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sat, 19 Sep 2009 04:50:07 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4222 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4222-submit@emacsbugs.donarmstrong.com id=B4222.125333540512522 (code B ref 4222); Sat, 19 Sep 2009 04:50:07 +0000 Original-Received: (at 4222) by emacsbugs.donarmstrong.com; 19 Sep 2009 04:43:25 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8J4hO5I012519 for <4222@emacsbugs.donarmstrong.com>; Fri, 18 Sep 2009 21:43:25 -0700 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8J4hBPU028611; Fri, 18 Sep 2009 21:43:12 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8J4hBNM011012; Fri, 18 Sep 2009 21:43:11 -0700 (PDT) In-Reply-To: <87skejomoe.fsf@stupidchicken.com> (Chong Yidong's message of "Fri, 18 Sep 2009 19:30:57 -0400") Original-Lines: 28 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8J4hBPU028611 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sat, 19 Sep 2009 01:07:09 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31281 Archived-At: Chong Yidong writes: > > Take src/config.h run C-x r t on it to insert a space in front of each > > line. > > > > Then build both emacs-23.1 and 22.3 with profiling enabled (-O2 -g -pg). > > Then run: > > > > emacs -Q -nw config.h > > M-: (indent-region (point-min)(point-max)) RET > > C-x C-c > > > > The 23.1 gprof results: > > > > Each sample counts as 0.01 seconds. > > % cumulative self self total > > time seconds seconds calls s/call s/call name > > 29.60 7.03 7.03 406111658 0.00 0.00 char_table_ref > > 26.72 13.37 6.34 4653244 0.00 0.00 forw_comment > > I can't reproduce this problem now. Following your recipe, I do observe > the indentation taking a looong time, but char_table_ref is not called. > Presumably, Handa-san's 2009-08-25 and 2009-08-27 changes fixed this. > Should I close the bug, or is there still a problem? There still is a problem, but it is not caused by char_table_ref, that part was fixed by Handa-san. It's up to you if you want to keep this bug, just retitle it, or close it.