From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#4446: remove ###autoload from ediff-hook.el Date: Wed, 16 Sep 2009 11:17:03 -0700 (PDT) Message-ID: <200909161817.n8GIH3Yg015497@godzilla.ics.uci.edu> References: <200909161118.n8GBIPDV012011@godzilla.ics.uci.edu> Reply-To: Dan Nicolaescu , 4446@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253125647 26702 80.91.229.12 (16 Sep 2009 18:27:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Sep 2009 18:27:27 +0000 (UTC) Cc: 4446@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 16 20:27:20 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MnzDn-0006S3-1i for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Sep 2009 20:27:15 +0200 Original-Received: from localhost ([127.0.0.1]:44494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnzDm-0003d4-HI for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Sep 2009 14:27:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MnzDg-0003cI-KJ for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 14:27:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MnzDc-0003aK-EL for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 14:27:08 -0400 Original-Received: from [199.232.76.173] (port=48786 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnzDc-0003a7-7i for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 14:27:04 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:35071) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MnzDb-0007wI-Cb for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 14:27:03 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8GIR0p5027898; Wed, 16 Sep 2009 11:27:00 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8GIP5Ms027574; Wed, 16 Sep 2009 11:25:05 -0700 Resent-Date: Wed, 16 Sep 2009 11:25:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Wed, 16 Sep 2009 18:25:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4446 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4446-submit@emacsbugs.donarmstrong.com id=B4446.125312503826446 (code B ref 4446); Wed, 16 Sep 2009 18:25:05 +0000 Original-Received: (at 4446) by emacsbugs.donarmstrong.com; 16 Sep 2009 18:17:18 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8GIHHcn026278 for <4446@emacsbugs.donarmstrong.com>; Wed, 16 Sep 2009 11:17:18 -0700 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8GIH4Yp022262; Wed, 16 Sep 2009 11:17:05 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8GIH3Yg015497; Wed, 16 Sep 2009 11:17:03 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 16 Sep 2009 09:22:42 -0400") Original-Lines: 29 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8GIH4Yp022262 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Wed, 16 Sep 2009 14:27:08 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31147 Archived-At: Stefan Monnier writes: > > The ###autoload in ediff-hook.el is not needed, this file is in the > > dumped image, so the autoload's only effect is to make loaddefs.el > > bigger and increase the size of the dumped image. > > > The comment in the file says that the autoload is needed for XEmacs, but > > that's not a good reason to keep it in the Emacs CVS, it's a one line > > change to a file that almost never changes. > > > OK to remove the autoload line? > > Actually, it reminds me that I faced a similar situation recently. > I did remove the autoload cookie, but in retrospect I think it was the > wrong thing to do. We should instead teach our build system to skip > preloaded files when creating the loaddefs.el file. I got rid of most of the autoloads in the preloaded files a couple of years ago, this must have fallen through the cracks. Skipping register.el while creating loaddefs.el would be wrong, nothing else would create the register bindings then. And there's 3 autoloads more in composite.el, that's all the autoloads in the unconditionally preloaded files. Given that there's so few autoloads left, it does not seem like a good idea to change the build system instead of just removing them. More, for the specific case of ediff-hook.el, IMO the best thing to do is got fold the emacs specific contents of that file into menu-bar.el and get rid of it. Almost all of the menu creation happens in menu-bar.el...