From: Dan Nicolaescu <dann@ics.uci.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 4446@emacsbugs.donarmstrong.com
Subject: bug#4446: remove ###autoload from ediff-hook.el
Date: Wed, 16 Sep 2009 11:17:03 -0700 (PDT) [thread overview]
Message-ID: <200909161817.n8GIH3Yg015497@godzilla.ics.uci.edu> (raw)
In-Reply-To: <jwvbplb3u00.fsf-monnier+emacsbugreports@gnu.org> (Stefan Monnier's message of "Wed, 16 Sep 2009 09:22:42 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> > The ###autoload in ediff-hook.el is not needed, this file is in the
> > dumped image, so the autoload's only effect is to make loaddefs.el
> > bigger and increase the size of the dumped image.
>
> > The comment in the file says that the autoload is needed for XEmacs, but
> > that's not a good reason to keep it in the Emacs CVS, it's a one line
> > change to a file that almost never changes.
>
> > OK to remove the autoload line?
>
> Actually, it reminds me that I faced a similar situation recently.
> I did remove the autoload cookie, but in retrospect I think it was the
> wrong thing to do. We should instead teach our build system to skip
> preloaded files when creating the loaddefs.el file.
I got rid of most of the autoloads in the preloaded files a couple of
years ago, this must have fallen through the cracks.
Skipping register.el while creating loaddefs.el would be wrong, nothing
else would create the register bindings then.
And there's 3 autoloads more in composite.el, that's all the autoloads
in the unconditionally preloaded files.
Given that there's so few autoloads left, it does not seem like a good
idea to change the build system instead of just removing them.
More, for the specific case of ediff-hook.el, IMO the best thing to do
is got fold the emacs specific contents of that file into menu-bar.el
and get rid of it. Almost all of the menu creation happens in menu-bar.el...
next prev parent reply other threads:[~2009-09-16 18:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <w7iqetxlhe.fsf@fencepost.gnu.org>
2009-09-16 11:18 ` bug#4446: remove ###autoload from ediff-hook.el Dan Nicolaescu
2009-09-16 11:32 ` Leo
2009-09-16 13:22 ` Stefan Monnier
2009-09-16 18:17 ` Dan Nicolaescu [this message]
2009-09-17 7:14 ` Glenn Morris
2009-09-17 18:11 ` Dan Nicolaescu
2009-09-17 21:01 ` Stefan Monnier
2009-09-24 3:28 ` Glenn Morris
2009-09-24 15:18 ` Stefan Monnier
2009-09-24 20:27 ` Glenn Morris
2009-09-24 22:12 ` Stefan Monnier
2009-09-25 18:16 ` Dan Nicolaescu
2009-09-25 21:29 ` Stefan Monnier
2009-09-26 19:18 ` Glenn Morris
2009-09-29 3:09 ` Stefan Monnier
2009-09-29 3:56 ` Dan Nicolaescu
2009-09-29 21:19 ` Stefan Monnier
2009-09-30 4:34 ` Dan Nicolaescu
2009-10-06 3:20 ` bug#4446: marked as done (remove ###autoload from ediff-hook.el) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909161817.n8GIH3Yg015497@godzilla.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=4446@emacsbugs.donarmstrong.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.