bug#4307: 23.1; vc-annotate should run svn asynchronously

bug#4307: 23.1; vc-annotate should run svn asynchronously

[Tom Tromey]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:


I typed "C-x v g" (vc-annotate) in a buffer in a source tree managed by
svn.

I expected "svn annotate" to run asynchronously.  This is what happens
for CVS.  Instead, it ran sychronously.



If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.1/etc/DEBUG for instructions.


In GNU Emacs 23.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.16.5)
 of 2009-08-24 on x86-2.fedora.phx.redhat.com
Windowing system distributor `The X.Org Foundation', version 11.0.10601901
configured using `configure  '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i586-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-dbus' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xft' '--with-xpm' '--with-x-toolkit=gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i586-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-bu
 ffer-size=4 -m32 -march=i586 -mtune=generic -fasynchronous-unwind-tables''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Makefile.am

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  auto-fill-function: do-auto-fill
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  erc-spelling-mode: t
  erc-truncate-mode: t
  erc-status-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
o <f10> <f10> <f10> C-z o n SPC n SPC SPC n n n q s 
SPC C-u d d d d C-l C-u d SPC M SPC = C-u d d C-u d 
d d d d d d C-u d d SPC n <help-echo> <help-echo> <down-mouse-2> 
<mouse-2> <help-echo> C-z o C-x C-f ~ / g n <tab> T 
r <tab> t r <tab> g <backspace> l i b j <tab> m <backspace> 
M a k <tab> a <tab> <return> C-s e c j x . c c C-a 
C-x C-f e c j x <tab> <return> C-x k <return> <f10> 
<f10> <f10> <f10> : - ) C-a C-d ; <return> <f10> <f10> 
<switch-frame> <help-echo> <help-echo> <switch-frame> 
<down-mouse-5> <mouse-5> <double-down-mouse-5> <double-mouse-5> 
<f10> <f10> <f10> <f10> f e d o r a SPC u p d a t e 
s SPC a r e SPC c r a z y ! <backspace> SPC t h i s 
SPC t i m e SPC a r o u n d <return> t h e r e SPC 
s e e m t SPC o b <backspace> <backspace> <backspace> 
<backspace> C-a a t SPC l e a s t , SPC t o SPC m e 
SPC t <backspace> C-e s SPC t o SPC b <M-backspace> 
<M-backspace> <backspace> <backspace> SPC t o SPC b 
e SPC a SPC l o t SPC m o r e SPC i n SPC F 1 1 SPC 
t h a n SPC b e f o r e <return> <f10> <f10> C-c b 
<f10> <f10> C-v C-l C-z o P <switch-frame> <switch-frame> 
<switch-frame> <f10> <f10> <f10> <f10> <f10> M-v M-> 
<f10> <f10> <f10> C-x v g C-z o C-z o M-x r e p o r 
t - e m <tab> b <tab> <return>

Recent messages:
Saving /home/tromey/.newsrc.eld...done
Retrieving newsgroup: nntp+news.gmane.org:gmane.comp.gcc.bugs...
Fetching headers for nntp+news.gmane.org:gmane.comp.gcc.bugs...done
Scoring...done
Generating summary...done
Mark saved where search started
Auto-saving...done
Mark set
Annotating...
Waiting for process to die...done
Quit
Tom

bug#4307: 23.1; vc-annotate should run svn asynchronously

[Dan Nicolaescu]

Tom Tromey <tromey@redhat.com> writes:

  > Please write in English if possible, because the Emacs maintainers
  > usually do not have translators to read other languages for them.
  > 
  > Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
  > and to the gnu.emacs.bug news group.
  > 
  > Please describe exactly what actions triggered the bug
  > and the precise symptoms of the bug:
  > 
  > 
  > I typed "C-x v g" (vc-annotate) in a buffer in a source tree managed by
  > svn.
  > 
  > I expected "svn annotate" to run asynchronously.  This is what happens
  > for CVS.  Instead, it ran sychronously.

If you want to work on this, just replace the " 0 " in
vc-svn-annotate-command with " 'async ".

Looking at the other backends, it looks like vc-mtn.el needs the same
treatment.

vc-bzr.el and vc-hg.el need that, plus the rest of their corresponding
vc-*-annotate-command functions needs to be moved inside a
`vc-exec-after'.

bug#4307: 23.1; vc-annotate should run svn asynchronously

[Tom Tromey]

>>>>> "Dan" == Dan Nicolaescu <dann@ics.uci.edu> writes:

Dan> If you want to work on this, just replace the " 0 " in
Dan> vc-svn-annotate-command with " 'async ".

I probably can't get to it, but I'll see what I can do.

I noticed that once the annotation is up, diffing a revision also runs
synchronously with vc-svn.

Tom

bug#4307: marked as done (23.1; vc-annotate should run svn asynchronously)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

Your message dated Wed, 16 Sep 2009 03:53:00 -0700 (PDT)
with message-id <200909161053.n8GAr0Nn011843@godzilla.ics.uci.edu>
and subject line Re: bug#4307: 23.1; vc-annotate should run svn asynchronously
has caused the Emacs bug report #4307,
regarding 23.1; vc-annotate should run svn asynchronously
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4307: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4307
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 7238 bytes --]

From: Tom Tromey <tromey@redhat.com>
To: bug-gnu-emacs@gnu.org
Subject: 23.1; vc-annotate should run svn asynchronously
Date: Tue, 01 Sep 2009 10:50:11 -0600
Message-ID: <m3k50ivccc.fsf@fleche.redhat.com>


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:


I typed "C-x v g" (vc-annotate) in a buffer in a source tree managed by
svn.

I expected "svn annotate" to run asynchronously.  This is what happens
for CVS.  Instead, it ran sychronously.



If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.1/etc/DEBUG for instructions.


In GNU Emacs 23.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.16.5)
 of 2009-08-24 on x86-2.fedora.phx.redhat.com
Windowing system distributor `The X.Org Foundation', version 11.0.10601901
configured using `configure  '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i586-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-dbus' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xft' '--with-xpm' '--with-x-toolkit=gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i586-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-bu
 ffer-size=4 -m32 -march=i586 -mtune=generic -fasynchronous-unwind-tables''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Makefile.am

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  auto-fill-function: do-auto-fill
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  erc-spelling-mode: t
  erc-truncate-mode: t
  erc-status-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
o <f10> <f10> <f10> C-z o n SPC n SPC SPC n n n q s 
SPC C-u d d d d C-l C-u d SPC M SPC = C-u d d C-u d 
d d d d d d C-u d d SPC n <help-echo> <help-echo> <down-mouse-2> 
<mouse-2> <help-echo> C-z o C-x C-f ~ / g n <tab> T 
r <tab> t r <tab> g <backspace> l i b j <tab> m <backspace> 
M a k <tab> a <tab> <return> C-s e c j x . c c C-a 
C-x C-f e c j x <tab> <return> C-x k <return> <f10> 
<f10> <f10> <f10> : - ) C-a C-d ; <return> <f10> <f10> 
<switch-frame> <help-echo> <help-echo> <switch-frame> 
<down-mouse-5> <mouse-5> <double-down-mouse-5> <double-mouse-5> 
<f10> <f10> <f10> <f10> f e d o r a SPC u p d a t e 
s SPC a r e SPC c r a z y ! <backspace> SPC t h i s 
SPC t i m e SPC a r o u n d <return> t h e r e SPC 
s e e m t SPC o b <backspace> <backspace> <backspace> 
<backspace> C-a a t SPC l e a s t , SPC t o SPC m e 
SPC t <backspace> C-e s SPC t o SPC b <M-backspace> 
<M-backspace> <backspace> <backspace> SPC t o SPC b 
e SPC a SPC l o t SPC m o r e SPC i n SPC F 1 1 SPC 
t h a n SPC b e f o r e <return> <f10> <f10> C-c b 
<f10> <f10> C-v C-l C-z o P <switch-frame> <switch-frame> 
<switch-frame> <f10> <f10> <f10> <f10> <f10> M-v M-> 
<f10> <f10> <f10> C-x v g C-z o C-z o M-x r e p o r 
t - e m <tab> b <tab> <return>

Recent messages:
Saving /home/tromey/.newsrc.eld...done
Retrieving newsgroup: nntp+news.gmane.org:gmane.comp.gcc.bugs...
Fetching headers for nntp+news.gmane.org:gmane.comp.gcc.bugs...done
Scoring...done
Generating summary...done
Mark saved where search started
Auto-saving...done
Mark set
Annotating...
Waiting for process to die...done
Quit
Tom



[-- Attachment #3: Type: message/rfc822, Size: 1967 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: 4307-done@emacsbugs.donarmstrong.com
Cc: Tom Tromey <tromey@redhat.com>
Subject: Re: bug#4307: 23.1; vc-annotate should run svn asynchronously
Date: Wed, 16 Sep 2009 03:53:00 -0700 (PDT)
Message-ID: <200909161053.n8GAr0Nn011843@godzilla.ics.uci.edu>

Fixed in CVS.