From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#4148: mode: for a minor mode should turn on, not toggle the mode Date: Sun, 16 Aug 2009 18:49:53 -0700 (PDT) Message-ID: <200908170149.n7H1nrbV022668@godzilla.ics.uci.edu> References: <874os9vuvd.fsf@cyd.mit.edu> <200908151854.n7FIsSHk009145@godzilla.ics.uci.edu> <87tz07gsap.fsf@cyd.mit.edu> Reply-To: Dan Nicolaescu , 4148@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1250474831 28827 80.91.229.12 (17 Aug 2009 02:07:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Aug 2009 02:07:11 +0000 (UTC) Cc: 4148@emacsbugs.donarmstrong.com To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 17 04:07:04 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mcrcl-0000ve-Fu for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Aug 2009 04:07:03 +0200 Original-Received: from localhost ([127.0.0.1]:48440 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mcrck-0008HV-RB for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Aug 2009 22:07:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mcrcg-0008HL-8M for bug-gnu-emacs@gnu.org; Sun, 16 Aug 2009 22:06:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mcrcb-0008Gq-Go for bug-gnu-emacs@gnu.org; Sun, 16 Aug 2009 22:06:57 -0400 Original-Received: from [199.232.76.173] (port=46913 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mcrcb-0008Gm-DJ for bug-gnu-emacs@gnu.org; Sun, 16 Aug 2009 22:06:53 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42277) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mcrca-0001YA-Dc for bug-gnu-emacs@gnu.org; Sun, 16 Aug 2009 22:06:53 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7H26oMo026449; Sun, 16 Aug 2009 19:06:50 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7H1t5fE023688; Sun, 16 Aug 2009 18:55:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 17 Aug 2009 01:55:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4148 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4148-submit@emacsbugs.donarmstrong.com id=B4148.125047380622908 (code B ref 4148); Mon, 17 Aug 2009 01:55:05 +0000 Original-Received: (at 4148) by emacsbugs.donarmstrong.com; 17 Aug 2009 01:50:06 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7H1o5XL022764 for <4148@emacsbugs.donarmstrong.com>; Sun, 16 Aug 2009 18:50:06 -0700 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n7H1nrn1009882; Sun, 16 Aug 2009 18:49:53 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n7H1nrbV022668; Sun, 16 Aug 2009 18:49:53 -0700 (PDT) In-Reply-To: <87tz07gsap.fsf@cyd.mit.edu> (Chong Yidong's message of "Sun, 16 Aug 2009 21:09:18 -0400") Original-Lines: 41 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n7H1nrn1009882 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sun, 16 Aug 2009 22:06:57 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30287 Archived-At: Chong Yidong writes: > Dan Nicolaescu writes: > > > Thanks, it seems to work fine. > > > > After this gets checked in, we can re-add (mode . bug-reference) to > > emacs/.dir-locals.el > > > > Any chance this patch can get onto the next release branch? > > I'm having trouble coming up with a test-case for testing this patch. > Do you have one? Here's one: $ cat foo.el (add-hook 'change-log-mode-hook (lambda () (bug-reference-mode 1))) $ cat emacs/.dir-locals.el ((nil . ((tab-width . 8) (fill-column . 70))) (c-mode . ((c-file-style . "GNU"))) (text-mode . ((mode . auto-fill))) (change-log-mode . ((add-log-time-zone-rule . t) (fill-column . 74) (bug-reference-url-format . "http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=%s") (mode . bug-reference)))) ;; arch-tag: fb93c160-e9fe-4184-aad1-e4f5daa11cbd $ emacs -Q -l foo.el C-x C-f emacs/lisp/ChangeLog C-h v bug-reference-mode RET before your patch bug-reference-mode is nil, after it's t