From: Dan Nicolaescu <dann@ics.uci.edu>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 4148@emacsbugs.donarmstrong.com
Subject: bug#4148: mode: for a minor mode should turn on, not toggle the mode
Date: Sun, 16 Aug 2009 18:49:53 -0700 (PDT) [thread overview]
Message-ID: <200908170149.n7H1nrbV022668@godzilla.ics.uci.edu> (raw)
In-Reply-To: <87tz07gsap.fsf@cyd.mit.edu> (Chong Yidong's message of "Sun, 16 Aug 2009 21:09:18 -0400")
Chong Yidong <cyd@stupidchicken.com> writes:
> Dan Nicolaescu <dann@ics.uci.edu> writes:
>
> > Thanks, it seems to work fine.
> >
> > After this gets checked in, we can re-add (mode . bug-reference) to
> > emacs/.dir-locals.el
> >
> > Any chance this patch can get onto the next release branch?
>
> I'm having trouble coming up with a test-case for testing this patch.
> Do you have one?
Here's one:
$ cat foo.el
(add-hook 'change-log-mode-hook (lambda () (bug-reference-mode 1)))
$ cat emacs/.dir-locals.el
((nil . ((tab-width . 8)
(fill-column . 70)))
(c-mode . ((c-file-style . "GNU")))
(text-mode . ((mode . auto-fill)))
(change-log-mode . ((add-log-time-zone-rule . t)
(fill-column . 74)
(bug-reference-url-format
. "http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=%s")
(mode . bug-reference))))
;; arch-tag: fb93c160-e9fe-4184-aad1-e4f5daa11cbd
$ emacs -Q -l foo.el
C-x C-f emacs/lisp/ChangeLog
C-h v bug-reference-mode RET
before your patch bug-reference-mode is nil, after it's t
next prev parent reply other threads:[~2009-08-17 1:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-15 17:40 bug#4148: mode: for a minor mode should turn on, not toggle the mode Chong Yidong
2009-08-15 18:54 ` Dan Nicolaescu
2009-08-17 1:09 ` Chong Yidong
2009-08-17 1:49 ` Dan Nicolaescu [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-08-15 7:05 Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908170149.n7H1nrbV022668@godzilla.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=4148@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.