From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#3973: cleanup view-mode usage in vc-resynch-window Date: Thu, 30 Jul 2009 00:44:58 -0700 (PDT) Message-ID: <200907300744.n6U7iwdl028160@godzilla.ics.uci.edu> Reply-To: Dan Nicolaescu , 3973@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1248940673 15048 80.91.229.12 (30 Jul 2009 07:57:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 30 Jul 2009 07:57:53 +0000 (UTC) To: bug-gnu-emacs Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 30 09:57:47 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MWQWH-0002Ww-D2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Jul 2009 09:57:45 +0200 Original-Received: from localhost ([127.0.0.1]:39049 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWQWG-0006dT-Jd for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Jul 2009 03:57:44 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWQWB-0006bq-3L for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 03:57:39 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWQW6-0006aS-GU for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 03:57:38 -0400 Original-Received: from [199.232.76.173] (port=49773 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWQW6-0006aP-9E for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 03:57:34 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:14205) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MWQW5-00080R-Qy for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 03:57:33 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWQW4-0008Op-PX for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 03:57:33 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6U7vVUf002492; Thu, 30 Jul 2009 00:57:31 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n6U7t6Q6002137; Thu, 30 Jul 2009 00:55:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 30 Jul 2009 07:55:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 3973 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12489400731494 (code B ref -1); Thu, 30 Jul 2009 07:55:05 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 30 Jul 2009 07:47:53 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6U7lmeC001487 for ; Thu, 30 Jul 2009 00:47:50 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWQMe-0003rG-K0 for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 03:47:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWQMa-0003pg-PE for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 03:47:48 -0400 Original-Received: from [199.232.76.173] (port=55431 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWQMa-0003pT-HU for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 03:47:44 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:13206) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MWQMZ-0006IY-GZ for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 03:47:43 -0400 Original-Received: from sallyv2.ics.uci.edu ([128.195.1.120]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWQL6-0007R8-Mq for bug-gnu-emacs@gnu.org; Thu, 30 Jul 2009 03:46:13 -0400 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n6U7iwSH004961 for ; Thu, 30 Jul 2009 00:44:59 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n6U7iwdl028160; Thu, 30 Jul 2009 00:44:58 -0700 (PDT) Original-Lines: 18 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n6U7iwSH004961 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-Detected-Operating-System: by mx20.gnu.org: Solaris 10 (beta) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Resent-Date: Thu, 30 Jul 2009 03:57:38 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:29727 Archived-At: vc-resynch-window contains this code: ;; TODO: Adjusting view mode might no longer be necessary ;; after RMS change to files.el of 1999-08-08. Investigate ;; this when we install the new VC. (and view-read-only (if (file-writable-p file) (and view-mode (let ((view-old-buffer-read-only nil)) (view-mode-exit))) (and (not view-mode) (not (eq (get major-mode 'mode-class) 'special)) (view-mode-enter)))) not sure what it's supposed to do... But the comment (added in Apr 2000!) seems to say that it can be removed. Should it?