crash in NS, 23.1, while loading font

crash in NS, 23.1, while loading font

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 2142 bytes --]

I reverted the  Jul 24 change locally:

"* nsfont.m (ns_findfonts): Correctly return fallback in match case."

and the bug outlined below went away, so I recommend revising or  
reverting this change before the release.

- David

On Jul 29, 2009, at 11:17 AM, David Reitter wrote:

> Adrian,
>
> could the crash below (which I get if calling about-emacs in  
> Aquamacs -Q with the latest changes) be related to your recent  
> changes to nsfont.m?
>
> I'm at a conference and can't debug this in detail (or with an  
> Emacs.app build), sorry.
>
> Best
> - David
>
>
> #0  0x91a04972 in __kill ()
> #1  0x91a04964 in kill$UNIX2003 ()
> #2  0x91a97ba1 in raise ()
> #3  0x91aadc58 in abort ()
> #4  0x001818e8 in font_open_entity ()
> #5  0x00183406 in font_open_for_lface ()
> #6  0x001834a6 in font_load_for_lface ()
> #7  0x000bba14 in Finternal_set_lisp_face_attribute ()
> #8  0x00169d67 in Ffuncall ()
> #9  0x001ba3c9 in Fbyte_code ()
> #10 0x0016a5a8 in funcall_lambda ()
> #11 0x00169f89 in Ffuncall ()
> #12 0x001ba3c9 in Fbyte_code ()
> #13 0x0016a5a8 in funcall_lambda ()
> #14 0x00169f89 in Ffuncall ()
> #15 0x001ba3c9 in Fbyte_code ()
> #16 0x0016a5a8 in funcall_lambda ()
> #17 0x00169f89 in Ffuncall ()
> #18 0x001ba3c9 in Fbyte_code ()
> #19 0x0016a5a8 in funcall_lambda ()
> #20 0x00169f89 in Ffuncall ()
> #21 0x001ba3c9 in Fbyte_code ()
> #22 0x0016a5a8 in funcall_lambda ()
> #23 0x00169f89 in Ffuncall ()
> #24 0x001ba3c9 in Fbyte_code ()
> #25 0x0016a5a8 in funcall_lambda ()
> #26 0x00169f89 in Ffuncall ()
> #27 0x001ba3c9 in Fbyte_code ()
> #28 0x0016a5a8 in funcall_lambda ()
> #29 0x00169f89 in Ffuncall ()
> #30 0x00169710 in apply1 ()
> #31 0x00162813 in Fcall_interactively ()
> #32 0x00169d1c in Ffuncall ()
> #33 0x001697d8 in call3 ()
> #34 0x000daba8 in Fcommand_execute ()
> #35 0x000c9fa1 in command_loop_1 ()
> #36 0x00167104 in internal_condition_case ()
> #37 0x000c7e12 in command_loop_2 ()
> #38 0x00166a95 in internal_catch ()
> #39 0x000c7d9b in command_loop ()
> #40 0x000c736f in recursive_edit_1 ()
> #41 0x000c7578 in Frecursive_edit ()
> #42 0x000c587e in main ()
> (gdb) xbacktrace
> (gdb)


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]

Re: crash in NS, 23.1, while loading font

[Chong Yidong]

David Reitter <david.reitter@gmail.com> writes:

> I reverted the  Jul 24 change locally:
>
> "* nsfont.m (ns_findfonts): Correctly return fallback in match case."
>
> and the bug outlined below went away, so I recommend revising or
> reverting this change before the release.

What bug was this change intended to fix?  Please reply ASAP.

Re: crash in NS, 23.1, while loading font

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

On Jul 29, 2009, at 3:34 PM, Chong Yidong wrote:

> What bug was this change intended to fix?  Please reply ASAP.


I didn't file a bug because I don't have time to isolate this with the  
vanilla 23.1 source.  I wanted to report it asap though because the  
crash was rather reproducible in my branch and it was directly related  
to that change.


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]

Re: crash in NS, 23.1, while loading font

[Adrian Robert]

On Jul 29, 2009, at 10:26 AM, David Reitter wrote:

> On Jul 29, 2009, at 3:34 PM, Chong Yidong wrote:
>
>> What bug was this change intended to fix?  Please reply ASAP.
>
>
> I didn't file a bug because I don't have time to isolate this with  
> the vanilla 23.1 source.  I wanted to report it asap though because  
> the crash was rather reproducible in my branch and it was directly  
> related to that change.

I've checked in a fix to trunk and branch (entity instead of list must  
be returned in match () case).

Re: crash in NS, 23.1, while loading font

[Chong Yidong]

David Reitter <david.reitter@gmail.com> writes:

> I reverted the  Jul 24 change locally:
>
> "* nsfont.m (ns_findfonts): Correctly return fallback in match case."
>
> and the bug outlined below went away, so I recommend revising or
> reverting this change before the release.
>
>> could the crash below (which I get if calling about-emacs in
>> Aquamacs -Q with the latest changes) be related to your recent

Strange, the 07-24 change looks legit to me.  Can anyone on this list
reproduce the crash (by calling about-emacs)?  If so, please debug, or
provide a backtrace with debugging symbols.

Re: crash in NS, 23.1, while loading font

[Harald Hanche-Olsen]

+ Chong Yidong <cyd@stupidchicken.com>:

> Strange, the 07-24 change looks legit to me.  Can anyone on this list
> reproduce the crash (by calling about-emacs)?

FWIW, I cannot reproduce it with an emacs compiled from git commit
f7519d6a353417fd043f3f0efb0fa75210cad134 dated Tue Jul 28 20:36:57
2009 +0000, doing this:

; ./configure --with-ns
; make bootstrap
; make install
; ./nextstep/Emacs.app/Contents/MacOS/Emacs -Q

and then typing C-h C-a. This should trigger the bug, right?
Well it doesn't happen for me.

- Harald

Re: crash in NS, 23.1, while loading font

[CHENG Gao]

*On Wed, 29 Jul 2009 09:59:20 -0500 (CDT)
* Also sprach Harald Hanche-Olsen <hanche@math.ntnu.no>:

> + Chong Yidong <cyd@stupidchicken.com>:
>
>> Strange, the 07-24 change looks legit to me.  Can anyone on this list
>> reproduce the crash (by calling about-emacs)?
>
> FWIW, I cannot reproduce it with an emacs compiled from git commit
> f7519d6a353417fd043f3f0efb0fa75210cad134 dated Tue Jul 28 20:36:57
> 2009 +0000, doing this:
>
> ; ./configure --with-ns
> ; make bootstrap
> ; make install
> ; ./nextstep/Emacs.app/Contents/MacOS/Emacs -Q
>
> and then typing C-h C-a. This should trigger the bug, right?
> Well it doesn't happen for me.
>
> - Harald

Same here. I build on July 28 from git source. It does not happen to me
either.