bug#3613: [PATCH] Allow trailing spaces and " -" in filenames for the compile output parser

bug#3613: [PATCH] Allow trailing spaces and " -" in filenames for the compile output parser

[Laurence Darby]

Hi,

I actually have a lot of files that have " -" in the names, this patch
fixes it for me.  If anyone understands this regex (I don't really,
just kept changing it till it worked), can you see if the change breaks
anything else?

Thanks,
Laurence

(Please CC me on replies, I'm not subscribed, thanks)

---
 lisp/progmodes/compile.el |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 11428d2..328f31f 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -245,11 +245,9 @@ of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?:" 3 2 nil (1))
      ;; line number starts with "SS".  --Stef
 
      ;; The core of the regexp is the one with *?.  It says that a file name
-     ;; can be composed of any non-newline char, but it also rules out some
-     ;; valid but unlikely cases, such as a trailing space or a space
-     ;; followed by a -.
+     ;; can be composed of any non-newline char.
      "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\
-\\([0-9]*[^0-9\n]\\(?:[^\n ]\\| [^-/\n]\\)*?\\): ?\
+\\([0-9]*[^0-9\n]\\(?:[^\n]\\| [^/\n]\\)*?\\): ?\
 \\([0-9]+\\)\\(?:\\([.:]\\)\\([0-9]+\\)\\)?\
 \\(?:-\\([0-9]+\\)?\\(?:\\.\\([0-9]+\\)\\)?\\)?:\
 \\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\
-- 
1.6.2.2

bug#3613: [PATCH] Allow trailing spaces and " -" in filenames for the compile output parser

[Stefan Monnier]

> I actually have a lot of files that have " -" in the names, this patch
> fixes it for me.  If anyone understands this regex (I don't really,
> just kept changing it till it worked), can you see if the change breaks
> anything else?

Your change turns the (core of) regexp back to just ".*?" as it was in
the past.  We disallowed trailing spaces as well as " -" because they
lead to false positives in some cases.
There's no way to win in all cases, sadly.


        Stefan