Re: load_charset warning

[Emanuele Giaquinta <emanuele.giaquinta@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

On Fri, May 01, 2009 at 07:56:23PM +0900, Kenichi Handa wrote:

> In article <20090501104053.GB37259@orion.local>, Emanuele Giaquinta <emanuele.giaquinta@gmail.com> writes:
> 
> > gcc emits the following warning for charset.c:load_charset:
> 
> > charset.c: In function 'load_charset':
> > charset.c:649: warning: comparisons like X<=Y<=Z do not have their mathematical meaning
> 
> > Since the code seems correct, i'd suggest the attached patch to
> > improve readability (and avoid the warning).
> 
> Thank you.  I committed your change.

I also noticed a useless assignment to for_encoder, see attached patch.

Emanuele Giaquinta

[-- Attachment #2: load_charset_map.diff --]
[-- Type: text/x-diff, Size: 359 bytes --]

diff --git a/src/charset.c b/src/charset.c
index 15975a4..7d9bc2f 100644
--- a/src/charset.c
+++ b/src/charset.c
@@ -319,7 +319,6 @@ load_charset_map (charset, entries, n_entries, control_flag)
 	    {
 	      memset (temp_charset_work->table.decoder, -1,
 		      sizeof (int) * 0x10000);
-	      temp_charset_work->for_encoder = 0;
 	    }
 	  else
 	    {