load_charset warning

[Emanuele Giaquinta <emanuele.giaquinta@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

Hi,

gcc emits the following warning for charset.c:load_charset:

charset.c: In function 'load_charset':
charset.c:649: warning: comparisons like X<=Y<=Z do not have their mathematical meaning

Since the code seems correct, i'd suggest the attached patch to
improve readability (and avoid the warning).

Emanuele Giaquinta

[-- Attachment #2: load_charset.diff --]
[-- Type: text/x-diff, Size: 480 bytes --]

diff --git a/src/charset.c b/src/charset.c
index 15975a4..107647f 100644
--- a/src/charset.c
+++ b/src/charset.c
@@ -646,7 +646,7 @@ load_charset (charset, control_flag)
   if (inhibit_load_charset_map
       && temp_charset_work
       && charset == temp_charset_work->current
-      && (control_flag == 2 == temp_charset_work->for_encoder))
+      && ((control_flag == 2) == temp_charset_work->for_encoder))
     return;
 
   if (CHARSET_METHOD (charset) == CHARSET_METHOD_MAP)