From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#2872: diff from log-view not working for bzr Date: Thu, 2 Apr 2009 19:09:56 -0700 (PDT) Message-ID: <200904030209.n3329uQj012191@godzilla.ics.uci.edu> Reply-To: Dan Nicolaescu , 2872@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1238725448 7946 80.91.229.12 (3 Apr 2009 02:24:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Apr 2009 02:24:08 +0000 (UTC) To: bug-gnu-emacs Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 03 04:25:26 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LpZ5x-0001wT-Ls for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Apr 2009 04:25:26 +0200 Original-Received: from localhost ([127.0.0.1]:42016 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LpZ4Z-0001RO-Gq for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Apr 2009 22:23:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LpZ4V-0001RA-I7 for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2009 22:23:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LpZ4Q-0001Q0-Jj for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2009 22:23:54 -0400 Original-Received: from [199.232.76.173] (port=39266 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LpZ4Q-0001Po-EK for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2009 22:23:50 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:41743) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LpZ4P-0006s1-Ja for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2009 22:23:49 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n332Nl1w006831; Thu, 2 Apr 2009 19:23:47 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n332K317005674; Thu, 2 Apr 2009 19:20:03 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 03 Apr 2009 02:20:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 2872 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12387247164160 (code B ref -1); Fri, 03 Apr 2009 02:20:03 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 3 Apr 2009 02:11:56 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n332BrM1004153 for ; Thu, 2 Apr 2009 19:11:54 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LpYsq-0006xV-Tc for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2009 22:11:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LpYsl-0006xA-GM for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2009 22:11:51 -0400 Original-Received: from [199.232.76.173] (port=40772 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LpYsl-0006x7-AP for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2009 22:11:47 -0400 Original-Received: from barrelv2.ics.uci.edu ([128.195.1.114]:51803) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1LpYsk-0005bn-Q5 for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2009 22:11:47 -0400 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n3329vYo001028 for ; Thu, 2 Apr 2009 19:09:57 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n3329uQj012191; Thu, 2 Apr 2009 19:09:56 -0700 (PDT) Original-Lines: 30 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n3329vYo001028 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_BZ 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 02 Apr 2009 22:23:54 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26865 Archived-At: Do a C-x v l on any file under bzr. Put the point on some random log entry and type d And empty *vc-diff* window will appear. The problem is that vc-bzr-diff gets called with the arguments REV1 == REV2. And that happens because of this code in log-view-diff: (log-view-msg-next) (setq to (log-view-current-tag)) [1] Given a log entry like this: ------------------------------------------------------------ revno: 295 `log-view-msg-next' puts the point at the beginning of the ---- line and `log-view-current-tag' returns the version of the _previous_ log entry. It happens because `log-view-current-tag' first does a (forward-line 1) --> point will be at "revno" after that. And then (re-search-backward log-view-message-re nil t) which will find the current log entry. So in conclusion code [1] fails to advance and find the next log entry.