From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#2604: 23.0.91; key bindings in vc-annotate incompatible w/ Emacs 22 Date: Mon, 16 Mar 2009 18:13:14 -0700 (PDT) Message-ID: <200903170113.n2H1DEDC011281@godzilla.ics.uci.edu> References: <87wsazehs7.fsf@marauder.physik.uni-ulm.de> <200903091748.n29HmjcZ018979@rodan.ics.uci.edu> <87k56ycvvy.fsf@marauder.physik.uni-ulm.de> Reply-To: Dan Nicolaescu , 2604@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1237253090 21200 80.91.229.12 (17 Mar 2009 01:24:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Mar 2009 01:24:50 +0000 (UTC) To: 2604@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 17 02:26:07 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LjO4E-0005Ra-2y for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Mar 2009 02:26:06 +0100 Original-Received: from localhost ([127.0.0.1]:33253 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LjO2r-0007IY-RJ for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Mar 2009 21:24:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LjO23-0006n0-4f for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2009 21:23:51 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LjO1x-0006kU-W8 for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2009 21:23:50 -0400 Original-Received: from [199.232.76.173] (port=44003 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LjO1x-0006kJ-OD for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2009 21:23:45 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:57005) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LjO1w-0004Wy-Uc for bug-gnu-emacs@gnu.org; Mon, 16 Mar 2009 21:23:45 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2H1NgHC012190; Mon, 16 Mar 2009 18:23:42 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n2H1K3as011052; Mon, 16 Mar 2009 18:20:03 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 17 Mar 2009 01:20:02 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2604 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2604-submit@emacsbugs.donarmstrong.com id=B2604.12372524089791 (code B ref 2604); Tue, 17 Mar 2009 01:20:02 +0000 Original-Received: (at 2604) by emacsbugs.donarmstrong.com; 17 Mar 2009 01:13:28 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2H1DPuK009785 for <2604@emacsbugs.donarmstrong.com>; Mon, 16 Mar 2009 18:13:26 -0700 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n2H1DELs002528 for <2604@emacsbugs.donarmstrong.com>; Mon, 16 Mar 2009 18:13:14 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n2H1DEDC011281; Mon, 16 Mar 2009 18:13:14 -0700 (PDT) In-Reply-To: <87k56ycvvy.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Mon, 09 Mar 2009 20:57:05 +0100") Original-Lines: 48 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n2H1DELs002528 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 16 Mar 2009 21:23:50 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26411 Archived-At: Reiner Steib writes: > On Mon, Mar 09 2009, Dan Nicolaescu wrote: > > > Reiner Steib writes: > > > - D > > > > > > Instead of showing diff of revision at line (as in Emacs 22), I get: > > > > > > ,----[ *Messages* ] > > > | vc-annotate-show-changeset-diff-revision-at-line: > > > | The CVS backend does not support changeset diffs > > > `---- > > > > > > Is this change intended? > > > > It is. > > > > > I could understand that `D' should now work > > > on change sets, but please at least mention it in NEWS and tell the > > > user to try `d' instead or better just display the warning and than > > > call `vc-annotate-show-diff-revision-at-line' if no change set > > > operation is available. > > > > I am not sure that is better. But if you can suggest a better wording > > for the error message, go for it. > > How about this? (Same in `log-view-diff-changeset', probably.) > > --- vc-annotate.el 09 Jan 2009 09:52:59 +0100 1.7 > +++ vc-annotate.el 09 Mar 2009 20:35:28 +0100 > @@ -506,7 +506,10 @@ > "Visit the diff of the revision at line from its previous revision for all files in the changeset." > (interactive) > (when (eq 'file (vc-call-backend vc-annotate-backend 'revision-granularity)) > - (error "The %s backend does not support changeset diffs" vc-annotate-backend)) > + (error > + (substitute-command-keys "The %s backend does not support changeset diffs. \ > +Use \\[vc-annotate-show-diff-revision-at-line] to diff this file.") > + vc-annotate-backend)) > (vc-annotate-show-diff-revision-at-line-internal nil)) > > (defun vc-annotate-warp-revision (revspec) I am not too convinced that this is better, but if you think it's better, then feel free to go ahead and change it. I added a note in NEWS about the key bindings.