From: Dan Nicolaescu <dann@ics.uci.edu>
To: 2604@emacsbugs.donarmstrong.com
Subject: bug#2604: 23.0.91; key bindings in vc-annotate incompatible w/ Emacs 22
Date: Mon, 16 Mar 2009 18:13:14 -0700 (PDT) [thread overview]
Message-ID: <200903170113.n2H1DEDC011281@godzilla.ics.uci.edu> (raw)
In-Reply-To: <87k56ycvvy.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Mon, 09 Mar 2009 20:57:05 +0100")
Reiner Steib <reinersteib+gmane@imap.cc> writes:
> On Mon, Mar 09 2009, Dan Nicolaescu wrote:
>
> > Reiner Steib <reinersteib+gmane@imap.cc> writes:
> > > - D
> > >
> > > Instead of showing diff of revision at line (as in Emacs 22), I get:
> > >
> > > ,----[ *Messages* ]
> > > | vc-annotate-show-changeset-diff-revision-at-line:
> > > | The CVS backend does not support changeset diffs
> > > `----
> > >
> > > Is this change intended?
> >
> > It is.
> >
> > > I could understand that `D' should now work
> > > on change sets, but please at least mention it in NEWS and tell the
> > > user to try `d' instead or better just display the warning and than
> > > call `vc-annotate-show-diff-revision-at-line' if no change set
> > > operation is available.
> >
> > I am not sure that is better. But if you can suggest a better wording
> > for the error message, go for it.
>
> How about this? (Same in `log-view-diff-changeset', probably.)
>
> --- vc-annotate.el 09 Jan 2009 09:52:59 +0100 1.7
> +++ vc-annotate.el 09 Mar 2009 20:35:28 +0100
> @@ -506,7 +506,10 @@
> "Visit the diff of the revision at line from its previous revision for all files in the changeset."
> (interactive)
> (when (eq 'file (vc-call-backend vc-annotate-backend 'revision-granularity))
> - (error "The %s backend does not support changeset diffs" vc-annotate-backend))
> + (error
> + (substitute-command-keys "The %s backend does not support changeset diffs. \
> +Use \\[vc-annotate-show-diff-revision-at-line] to diff this file.")
> + vc-annotate-backend))
> (vc-annotate-show-diff-revision-at-line-internal nil))
>
> (defun vc-annotate-warp-revision (revspec)
I am not too convinced that this is better, but if you think it's
better, then feel free to go ahead and change it.
I added a note in NEWS about the key bindings.
next prev parent reply other threads:[~2009-03-17 1:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-08 23:06 bug#2604: 23.0.91; key bindings in vc-annotate incompatible w/ Emacs 22 Reiner Steib
2009-03-09 17:48 ` Dan Nicolaescu
2009-03-09 19:57 ` Reiner Steib
2009-03-10 0:42 ` Dan Nicolaescu
2009-03-10 0:59 ` Stefan Monnier
2009-03-10 21:30 ` Dan Nicolaescu
2009-03-11 2:06 ` Stefan Monnier
2009-03-17 1:13 ` Dan Nicolaescu [this message]
2009-03-09 17:49 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903170113.n2H1DEDC011281@godzilla.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=2604@emacsbugs.donarmstrong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.