From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#2388: 23.0.90; wrong-type-argument in vc-dir Date: Tue, 10 Mar 2009 14:11:01 -0700 (PDT) Message-ID: <200903102111.n2ALB1OM029132@godzilla.ics.uci.edu> References: <87zlgi1p9f.fsf@tnei.co.uk> <200902201612.n1KGCFvg006453@rodan.ics.uci.edu> <49A2B431.6030302@tnei.co.uk> <18851.37147.636647.611430@kahikatea.snap.net.nz> <18862.21659.153250.510667@snap.net.nz> <49B6361C.8050702@tnei.co.uk> Reply-To: Dan Nicolaescu , 2388@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236720270 1686 80.91.229.12 (10 Mar 2009 21:24:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Mar 2009 21:24:30 +0000 (UTC) Cc: 2388@emacsbugs.donarmstrong.com To: robert marshall Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 10 22:25:46 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Lh9Rq-0004nB-BX for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Mar 2009 22:25:14 +0100 Original-Received: from localhost ([127.0.0.1]:33086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lh9QU-0000ZR-Io for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Mar 2009 17:23:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lh9QO-0000Xz-Vb for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2009 17:23:45 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lh9QO-0000XD-Bl for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2009 17:23:44 -0400 Original-Received: from [199.232.76.173] (port=46150 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lh9QO-0000X2-0V for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2009 17:23:44 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:34201) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lh9QN-0007Lh-6t for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2009 17:23:43 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2ALNfNP013413; Tue, 10 Mar 2009 14:23:41 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n2ALK3En012336; Tue, 10 Mar 2009 14:20:03 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , owner@emacsbugs.donarmstrong.com Resent-Date: Tue, 10 Mar 2009 21:20:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2388 X-Emacs-PR-Package: emacs,vc-dir X-Emacs-PR-Keywords: Original-Received: via spool by 2388-submit@emacsbugs.donarmstrong.com id=B2388.123671947910942 (code B ref 2388); Tue, 10 Mar 2009 21:20:03 +0000 Original-Received: (at 2388) by emacsbugs.donarmstrong.com; 10 Mar 2009 21:11:19 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2ALBFIR010936 for <2388@emacsbugs.donarmstrong.com>; Tue, 10 Mar 2009 14:11:17 -0700 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n2ALB2uA019830; Tue, 10 Mar 2009 14:11:02 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n2ALB1OM029132; Tue, 10 Mar 2009 14:11:01 -0700 (PDT) In-Reply-To: <49B6361C.8050702@tnei.co.uk> (robert marshall's message of "Tue, 10 Mar 2009 09:42:52 +0000") Original-Lines: 85 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n2ALB2uA019830 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_SV 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 10 Mar 2009 17:23:44 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26215 Archived-At: robert marshall writes: > Nick Roberts wrote: > > Nick Roberts writes: > > > > > I can't reproduce this. > > > > > Can you please post step by step recipe of how you get this, starting > > > > > with emacs -Q. > > > The output of > > > svn -u status > > > > > in that directory might be helpful too. > > > > > > > I can't reproduce this either now :-( > > > > I have seen this sometimes when files have needed > > merging/updating. I don't > > > think it happened earlier because with SVN emacs didn't consult the remote > > > repository by default: > > > > I still see this. Here's a recent backtrace: > > > > Debugger entered--Lisp error: (wrong-type-argument arrayp nil) > > ewoc-data(nil) > > (let ((data ...)) (or (vc-dir-fileinfo->directory data) > > (file-name-directory ...))) > > vc-dir-node-directory(nil) > > (let* ((rd ...) (prev-node ...) (prev-dir ...)) (unless > > (string-equal entrydir prev-dir) (ewoc-enter-before vc-ewoc node > > ...))) > > (cond ((string-lessp nodedir entrydir) (setq node ...)) > > ((string-equal nodedir entrydir) (let ... ...)) (t (let* ... ...) > > (ewoc-enter-before vc-ewoc node ...) (setq entries ... entry ...))) > > (let* ((entryfile ...) (entrydir ...) (nodedir ...)) (cond > > (... ...) (... ...) (t ... ... ...))) > > (while (and entry node) (let* (... ... ...) (cond ... ... ...))) > > (let ((entry ...) (node ...) (dotname ...)) (unless node > > (ewoc-enter-last vc-ewoc ...) (setq node ...)) (while (and entry > > node) (let* ... ...)) (unless (or node noinsert) (let ... ...))) > > (save-current-buffer (set-buffer buffer) (setq entries (sort > > entries ...)) (let (... ... ...) (unless node ... ...) (while > > ... ...) (unless ... ...))) > > (with-current-buffer buffer (setq entries (sort entries ...)) (let > > (... ... ...) (unless node ... ...) (while ... ...) (unless > > ... ...))) > > vc-dir-update((("." needs-update) ("mydir" needs-update) > > ("pom.xml" needs-update) ("mydir1/mydir2/myfile" needs-update) ... > > > > which fails because node, i.e (ewoc-nth vc-ewoc 0), is nil. > > > > > I'm seeing this, today, the status gives me > > svn -u status > * 7243 tests/compare.py > * 7243 tests/harm.py > * 7243 tests/setup-win.py > * 7243 ipsa.i > * 7243 Makefile > * 7243 IscNetComponent.cpp > * 7243 IscNetComparator.h > * 7243 IpsaComparator.cpp > * 7243 IscNetComponent.h > * 7243 IscNetComparator.cpp > * IscCompareData.h > ? ipsa_wrap.cpp > M * 7243 IscInterface.cpp > ? ipsa.py > * IscCompareData.cpp > * 7243 Scripting.vcproj > * 7243 . ^^^^^^^^^^^^^^^^^^^^^^^^ This might be the cause of the problem. Can you please try thing patch: Index: vc-svn.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/vc-svn.el,v retrieving revision 1.112 diff -u -3 -p -u -p -r1.112 vc-svn.el --- vc-svn.el 10 Feb 2009 05:59:14 -0000 1.112 +++ vc-svn.el 10 Mar 2009 20:49:23 -0000 @@ -176,7 +176,7 @@ want to force an empty list of arguments ;; FIXME are there other possible combinations? (cond ((eq state 'edited) (setq state 'needs-merge)) ((not state) (setq state 'needs-update)))) - (when state + (when (and state (not (string= "." filename))) (setq result (cons (list filename state) result))))) (funcall callback result)))